Remove non-template fields from our test templates. #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
uakyol
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
Reviewed 17 of 17 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
SanjayVas
force-pushed
the
sanjayvas-reporting-tls
branch
from
50927e9 to
35ed277
Compare
SanjayVas
force-pushed
the
sanjayvas-labeled-events
branch
from
dc8c6b2 to
7573708
Compare
SanjayVas
force-pushed
the
sanjayvas-labeled-events
branch
from
7573708 to
a692cb2
Compare
SanjayVas
requested review from
Marco-Premier and
stevenwarejones
and removed request for
Marco-Premier
SanjayVas
force-pushed
the
sanjayvas-labeled-events
branch
from
a692cb2 to
631158f
Compare
stevenwarejones
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Reviewed 16 of 17 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:
Every field on an event message should use a message type that has an event_template annotation, and every field on a template message should have a template_field annotation.
SanjayVas
force-pushed
the
sanjayvas-labeled-events
branch
from
631158f to
25e8e68
Compare
ple13
pushed a commit
that referenced
this pull request
Aug 16, 2024
Every field on an event message should use a message type that has an event_template annotation, and every field on a template message should have a template_field annotation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every field on an event message should use a message type that has an event_template annotation, and every field on a template message should have a template_field annotation.