Herald supports reach-only llv2 protocol.

[renjiezh]

Depends on #1125

[wfa-reviewable]

This change is 

[kungfucraig]

Reviewed 8 of 38 files at r1, 30 of 30 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ple13, @renjiezh, and @SanjayVas)

---

src/main/kotlin/org/wfanet/measurement/duchy/daemon/herald/ReachOnlyLiquidLegionsV2Starter.kt line 80 at r2 (raw file):

        globalComputationId = globalId
        computationDetails = initialComputationDetails
        this.requisitions += requisitions

Why +=?

---

src/main/kotlin/org/wfanet/measurement/duchy/daemon/herald/ReachOnlyLiquidLegionsV2Starter.kt line 174 at r2 (raw file):

      }

      // For future stages, we log and exit.

Do we expect to ever log this? It seems like the client should know better than to call this function.

Maybe this is more a warning than info? I suppose we'd want to be consistent with the full LLv2 convention though.

---

src/main/kotlin/org/wfanet/measurement/duchy/daemon/herald/ReachOnlyLiquidLegionsV2Starter.kt line 202 at r2 (raw file):

  ) {
    require(token.computationDetails.hasReachOnlyLiquidLegionsV2()) {
      "Liquid Legions V2 computation required"

Please add "reach only" to the message somewhere.

[renjiezh]

Reviewable status: 37 of 39 files reviewed, 3 unresolved discussions (waiting on @kungfucraig, @ple13, and @SanjayVas)

---

src/main/kotlin/org/wfanet/measurement/duchy/daemon/herald/ReachOnlyLiquidLegionsV2Starter.kt line 80 at r2 (raw file):

Previously, kungfucraig (Craig Wright) wrote…

Why +=?

I think this is the way to set a list using DSL.

---

src/main/kotlin/org/wfanet/measurement/duchy/daemon/herald/ReachOnlyLiquidLegionsV2Starter.kt line 174 at r2 (raw file):

Previously, kungfucraig (Craig Wright) wrote…

Do we expect to ever log this? It seems like the client should know better than to call this function.

Maybe this is more a warning than info? I suppose we'd want to be consistent with the full LLv2 convention though.

You're right. The is to log for Computations with unexpected state. The logging level should be warning. I also updated other occurrences.

---

src/main/kotlin/org/wfanet/measurement/duchy/daemon/herald/ReachOnlyLiquidLegionsV2Starter.kt line 202 at r2 (raw file):

Previously, kungfucraig (Craig Wright) wrote…

Please add "reach only" to the message somewhere.

Done.
Nice catch.

[kungfucraig]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ple13 and @SanjayVas)

[ple13]

Reviewed 7 of 38 files at r1, 30 of 30 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @renjiezh and @SanjayVas)

---

src/main/kotlin/org/wfanet/measurement/duchy/daemon/herald/ReachOnlyLiquidLegionsV2Starter.kt line 319 at r3 (raw file):

                    globalReachDpNoise = reach.privacyParams.toDuchyDifferentialPrivacyParams()
                  }
                  MeasurementSpec.MeasurementTypeCase.REACH_AND_FREQUENCY -> {

Do we need to check for the case REACH_AND_FREQUENCY?

[renjiezh]

Reviewable status: 38 of 39 files reviewed, 1 unresolved discussion (waiting on @kungfucraig, @ple13, and @SanjayVas)

---

src/main/kotlin/org/wfanet/measurement/duchy/daemon/herald/ReachOnlyLiquidLegionsV2Starter.kt line 319 at r3 (raw file):

Previously, ple13 (Phi) wrote…

Do we need to check for the case REACH_AND_FREQUENCY?

Nice catch!
I just delete it. It is an error that Rollv2 receives type of REACH_AND_FREQUENCY.

[ple13]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

[SanjayVas]

Reviewed 7 of 38 files at r1, 30 of 30 files at r2, 1 of 2 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Marco-Premier and @renjiezh)

---

src/main/proto/wfa/measurement/internal/duchy/protocol/reach_only_liquid_legions_sketch_aggregation_v2.proto line 104 at r4 (raw file):

      // Parameters used for reachOnlyLiquidLegions sketch creation and
      // estimation.
      LiquidLegionsSketchParameters reach_only_liquid_legions_sketch = 1;

nit: This field rename seems unnecessary given that it's nested inside of ReachOnlyLiquidLegionsSketchAggregationV2.

Code quote:

reach_only_liquid_legions_sketch 

---

src/test/kotlin/org/wfanet/measurement/duchy/daemon/herald/HeraldTest.kt line 404 at r4 (raw file):

  @Test
  fun `syncStatuses creates a new llv2 computations`() = runTest {

Is there a single computation or multiple? (either "a new LLv2 Computation" or "new LLv2 Computations")

Code quote:

 a new llv2 computations

[renjiezh]

Reviewable status: 36 of 41 files reviewed, 1 unresolved discussion (waiting on @kungfucraig, @Marco-Premier, @ple13, and @SanjayVas)

---

src/test/kotlin/org/wfanet/measurement/duchy/daemon/herald/HeraldTest.kt line 404 at r4 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

Is there a single computation or multiple? (either "a new LLv2 Computation" or "new LLv2 Computations")

Done.

[SanjayVas]

Reviewed 5 of 5 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Marco-Premier)

[Marco-Premier]

Reviewed 5 of 38 files at r1, 30 of 30 files at r2, 1 of 2 files at r3, 5 of 5 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @renjiezh)

---

src/main/k8s/testing/secretfiles/non_aggregator_protocols_setup_config.textproto line 10 at r5 (raw file):

  role: NON_AGGREGATOR
  external_aggregator_duchy_id: "aggregator"
}

Nit missing new line?

Code quote:

}

[renjiezh]

Reviewed 4 of 38 files at r1, 30 of 30 files at r2, 1 of 2 files at r3, 5 of 5 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @renjiezh)

[SanjayVas]

Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @renjiezh)