Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SyntheticGenerator to be used for correctness test on GKE. #1127

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

SanjayVas
Copy link
Member

No description provided.

@wfa-reviewable
Copy link

This change is Reviewable

@SanjayVas SanjayVas force-pushed the sanjayvas-edp-simulator-gke branch 2 times, most recently from 2b55b2e to 7f63e65 Compare July 21, 2023 19:58
Copy link
Contributor

@tristanvuong2021 tristanvuong2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r1, 1 of 1 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas SanjayVas force-pushed the sanjayvas-edp-simulator branch from c3f44b4 to e41021c Compare July 25, 2023 17:10
@SanjayVas SanjayVas force-pushed the sanjayvas-edp-simulator-gke branch from 7f63e65 to b71a16e Compare July 25, 2023 17:10
@SanjayVas SanjayVas force-pushed the sanjayvas-edp-simulator branch from e41021c to d041c69 Compare July 25, 2023 17:14
@SanjayVas SanjayVas force-pushed the sanjayvas-edp-simulator-gke branch from b71a16e to cc4ef9d Compare July 25, 2023 17:14
Copy link
Contributor

@tristanvuong2021 tristanvuong2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

Base automatically changed from sanjayvas-edp-simulator to main July 25, 2023 18:48
@SanjayVas SanjayVas force-pushed the sanjayvas-edp-simulator-gke branch from cc4ef9d to 163049c Compare July 25, 2023 18:51
@SanjayVas SanjayVas requested a review from Marco-Premier July 25, 2023 20:37
@SanjayVas SanjayVas force-pushed the sanjayvas-edp-simulator-gke branch from 163049c to 5dd3075 Compare July 26, 2023 21:02
Copy link
Contributor

@Marco-Premier Marco-Premier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 8 files at r1, 2 of 2 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas SanjayVas merged commit 83512a4 into main Jul 27, 2023
@SanjayVas SanjayVas deleted the sanjayvas-edp-simulator-gke branch July 27, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants