Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix K8s dev config error of missing rollv2 textproto. #1119

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

renjiezh
Copy link
Contributor

No description provided.

@wfa-reviewable
Copy link

This change is Reviewable

@renjiezh renjiezh requested a review from SanjayVas July 19, 2023 19:03
@renjiezh
Copy link
Contributor Author

Hi @SanjayVas, could you please trigger the deployment you need to verify the fix? Thanks a lot!

@SanjayVas SanjayVas temporarily deployed to dev July 19, 2023 21:09 — with GitHub Actions Inactive
@SanjayVas SanjayVas temporarily deployed to dev July 19, 2023 21:13 — with GitHub Actions Inactive
@SanjayVas SanjayVas temporarily deployed to dev July 19, 2023 21:13 — with GitHub Actions Inactive
@SanjayVas SanjayVas temporarily deployed to dev July 19, 2023 21:13 — with GitHub Actions Inactive
@SanjayVas SanjayVas temporarily deployed to dev July 19, 2023 21:13 — with GitHub Actions Inactive
@SanjayVas SanjayVas temporarily deployed to dev July 19, 2023 21:13 — with GitHub Actions Inactive
@SanjayVas SanjayVas temporarily deployed to dev July 19, 2023 21:13 — with GitHub Actions Inactive
@SanjayVas SanjayVas temporarily deployed to dev July 19, 2023 21:18 — with GitHub Actions Inactive
Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @renjiezh)

Copy link
Contributor

@YuhongWang-Amazon YuhongWang-Amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Marco-Premier)

@renjiezh renjiezh enabled auto-merge (squash) July 20, 2023 17:00
@renjiezh renjiezh merged commit ef44ec1 into main Jul 20, 2023
@renjiezh renjiezh deleted the renjiez-rollv2-textproto-fix branch July 20, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants