-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reporting v2 cli tool. #1116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 7 files at r1, 1 of 2 files at r2, all commit messages.
Reviewable status: 5 of 7 files reviewed, 2 unresolved discussions (waiting on @tristanvuong2021)
src/main/kotlin/org/wfanet/measurement/reporting/service/api/v2alpha/tools/Reporting.kt
line 164 at r2 (raw file):
) } }
What if the user doesn't provider either?
Code quote:
if (type.cmmsEventGroups != null && type.cmmsEventGroups!!.isNotEmpty()) {
primitive =
ReportingSetKt.primitive { type.cmmsEventGroups!!.forEach { cmmsEventGroups += it } }
} else if (type.textFormatSetExpression != null) {
composite =
ReportingSetKt.composite {
expression =
parseTextProto(
type.textFormatSetExpression!!.reader(),
ReportingSet.SetExpression.getDefaultInstance()
)
}
}
src/main/kotlin/org/wfanet/measurement/reporting/service/api/v2alpha/tools/Reporting.kt
line 235 at r2 (raw file):
names = ["--reporting-metric-entry"], description = ["ReportingMetricEntry protobuf messages in text format"], required = false,
Based on v2alpha/report.proto
, it should be required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 7 files at r1, 1 of 2 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @tristanvuong2021)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 6 of 7 files reviewed, 2 unresolved discussions (waiting on @riemanli)
src/main/kotlin/org/wfanet/measurement/reporting/service/api/v2alpha/tools/Reporting.kt
line 164 at r2 (raw file):
Previously, riemanli (Rieman) wrote…
What if the user doesn't provider either.
It will throw an error. Multiplicity of "1" makes it required.
src/main/kotlin/org/wfanet/measurement/reporting/service/api/v2alpha/tools/Reporting.kt
line 235 at r2 (raw file):
Previously, riemanli (Rieman) wrote…
Based on
v2alpha/report.proto
, it should be required.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tristanvuong2021)
src/main/kotlin/org/wfanet/measurement/reporting/service/api/v2alpha/tools/Reporting.kt
line 235 at r2 (raw file):
Previously, tristanvuong2021 (Tristan Vuong) wrote…
Done.
Could you add a unit test of when there is no reporting metric entry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 6 of 7 files reviewed, 1 unresolved discussion (waiting on @riemanli)
src/main/kotlin/org/wfanet/measurement/reporting/service/api/v2alpha/tools/Reporting.kt
line 235 at r2 (raw file):
Previously, riemanli (Rieman) wrote…
Could you add a unit test of when there is no reporting metric entry?
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @tristanvuong2021)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 7 files at r1, 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tristanvuong2021)
src/test/kotlin/org/wfanet/measurement/reporting/service/api/v2alpha/tools/reporting_metric_entry.textproto
line 19 at r4 (raw file):
} } }
nit: new line
Code quote:
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @tristanvuong2021)
No description provided.