Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate duchy postgres package to deploy/common #1103

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

YuhongWang-Amazon
Copy link
Contributor

This migrates duchy postgres package from duchy/deploy/ to duchy/deploy/common/.

@wfa-reviewable
Copy link

This change is Reviewable

Copy link
Contributor Author

@YuhongWang-Amazon YuhongWang-Amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 19 files reviewed, 1 unresolved discussion

a discussion (no related file):
@SanjayVas we discussed that this postgres package should go to common directory. Since I am splitting that large PR out, I think it is good time to migrate before this package gets too large.


Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 19 of 19 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @renjiezh)

Copy link
Contributor

@renjiezh renjiezh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 19 of 19 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion

Copy link
Contributor

@renjiezh renjiezh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @renjiezh and @SanjayVas)

@YuhongWang-Amazon YuhongWang-Amazon enabled auto-merge (squash) July 19, 2023 13:50
@YuhongWang-Amazon YuhongWang-Amazon merged commit e34c15b into main Jul 19, 2023
@YuhongWang-Amazon YuhongWang-Amazon deleted the yuhong.postgres-duchy-readers branch July 19, 2023 13:57
ple13 pushed a commit that referenced this pull request Aug 16, 2024
This migrates duchy postgres package from duchy/deploy/ to
duchy/deploy/common/.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants