Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deployment Images for Reporting V2 #1099

Merged

Conversation

tristanvuong2021
Copy link
Contributor

No description provided.

@wfa-reviewable
Copy link

This change is Reviewable

@tristanvuong2021 tristanvuong2021 marked this pull request as ready for review July 11, 2023 22:30
Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @tristanvuong2021)

a discussion (no related file):
Note that after this point we should probably lock the initial schema changeset and require additional schema changes to be done in new changesets.



src/main/kotlin/org/wfanet/measurement/reporting/deploy/v2/gcloud/postgres/server/GCloudPostgresInternalReportingServer.kt line 37 at r1 (raw file):

  showDefaultValues = true
)
class GCloudPostgresReportingDataServer : InternalReportingServer() {

nit: Drop Data

Code quote:

DataServer

@tristanvuong2021 tristanvuong2021 changed the title Add Deployment Binaries for Reporting V2 Add Deployment Images for Reporting V2 Jul 12, 2023
Base automatically changed from tristanvuong-partial-implementation-of-integration-tests-reporting-v2 to main July 13, 2023 14:54
@tristanvuong2021 tristanvuong2021 force-pushed the tristanvuong-deployment-binaries-for-reporting-v2 branch from 405b519 to 07aade0 Compare July 13, 2023 14:58
Copy link
Contributor

@Marco-Premier Marco-Premier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 13 files at r1, 2 of 2 files at r2, 2 of 3 files at r3, 3 of 3 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tristanvuong2021)

Copy link
Contributor

@Marco-Premier Marco-Premier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tristanvuong2021)

@tristanvuong2021 tristanvuong2021 merged commit 5eac37b into main Jul 19, 2023
@tristanvuong2021 tristanvuong2021 deleted the tristanvuong-deployment-binaries-for-reporting-v2 branch July 19, 2023 15:29
ple13 pushed a commit that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants