-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Deployment Images for Reporting V2 #1099
Add Deployment Images for Reporting V2 #1099
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @tristanvuong2021)
a discussion (no related file):
Note that after this point we should probably lock the initial schema changeset and require additional schema changes to be done in new changesets.
src/main/kotlin/org/wfanet/measurement/reporting/deploy/v2/gcloud/postgres/server/GCloudPostgresInternalReportingServer.kt
line 37 at r1 (raw file):
showDefaultValues = true ) class GCloudPostgresReportingDataServer : InternalReportingServer() {
nit: Drop Data
Code quote:
DataServer
405b519
to
07aade0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 13 files at r1, 2 of 2 files at r2, 2 of 3 files at r3, 3 of 3 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tristanvuong2021)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tristanvuong2021)
No description provided.