-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cross-media-measurement-api for EventGroup pattern. #1063
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 20 files reviewed, 1 unresolved discussion (waiting on @SanjayVas and @tristanvuong2021)
a discussion (no related file):
Need to fix the v2 EventGroupKey.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 20 of 20 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @SanjayVas)
src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/writers/DeleteEventGroup.kt
line 38 at r1 (raw file):
* Throws one of the following [KingdomInternalException] types on [execute]: * * [EventGroupNotFoundException] EventGroup not found * * [EventGroupNotFoundByMeasurementConsumerException] EventGroup not found
This exception was added in the comment, but I don't see it used here.
bcf13f4
to
9b3591a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 19 of 20 files reviewed, 1 unresolved discussion (waiting on @tristanvuong2021)
a discussion (no related file):
Previously, SanjayVas (Sanjay Vasandani) wrote…
Need to fix the v2 EventGroupKey.
I split that out into #1064 instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 19 of 20 files reviewed, 1 unresolved discussion (waiting on @tristanvuong2021)
src/main/kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/writers/DeleteEventGroup.kt
line 38 at r1 (raw file):
Previously, tristanvuong2021 (Tristan Vuong) wrote…
This exception was added in the comment, but I don't see it used here.
Done.
I had originally tried to support Delete by the secondary pattern, but then realized only DataProviders can delete event groups anyway.
2e5c8b3
to
e977044
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 20 files at r1, 1 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
src/main/kotlin/org/wfanet/measurement/api/v2alpha/EventGroupKey.kt
line 24 at r3 (raw file):
/** [ResourceKey] of an EventGroup. */ data class EventGroupKey(val dataProviderId: String, val eventGroupId: String) : ChildResourceKey {
rename to DataProviderEventGroupKey
e977044
to
85f44d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 20 of 23 files reviewed, 1 unresolved discussion (waiting on @stevenwarejones and @tristanvuong2021)
src/main/kotlin/org/wfanet/measurement/api/v2alpha/EventGroupKey.kt
line 24 at r3 (raw file):
Previously, stevenwarejones (Steven Ware Jones) wrote…
rename to DataProviderEventGroupKey
The naming is intentional. The ResourceKey
type without a prefix is the canonical ones. The ones with prefixes are the non-canonical ones.
85f44d2
to
7943b20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @stevenwarejones)
7943b20
to
0e514de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @stevenwarejones)
0e514de
to
21ff462
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 16 of 20 files at r1, 1 of 1 files at r2, 2 of 2 files at r3, 2 of 3 files at r4, 1 of 1 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @stevenwarejones)
21ff462
to
5797103
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r7, all commit messages.
Dismissed @stevenwarejones from a discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @stevenwarejones)
5797103
to
443c1e1
Compare
443c1e1
to
1320cd3
Compare
Review taken over by @Marco-Premier
No description provided.