Add listReport

[riemanli]

No description provided.

[wfa-reviewable]

This change is 

[riemanli]

Current dependencies on/for this PR:

• main
  • PR Add MetricSpecBuilder. #1041
    • PR Add createReport. #1004
      • PR Add getReport. #1029
        • PR Add listReport #1053 👈
          • PR Divide batch requests to several calls #1046

This comment was auto-generated by Graphite.

[tristanvuong2021]

Reviewed 1 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jcorilla and @riemanli)

---

src/main/kotlin/org/wfanet/measurement/reporting/service/api/v2alpha/ReportsService.kt line 344 at r2 (raw file):

      }

      val metrics: List<Metric> =

You don't need this. You already have the map so externalIdToMetricMap.values would work.

[riemanli]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jcorilla and @tristanvuong2021)

---

src/main/kotlin/org/wfanet/measurement/reporting/service/api/v2alpha/ReportsService.kt line 344 at r2 (raw file):

Previously, tristanvuong2021 (Tristan Vuong) wrote…

You don't need this. You already have the map so externalIdToMetricMap.values would work.

This is for the case of listReports. The externalIdToMetricMap provided from listReports is for all metrics used across reports, so I need to get the list of metrics that are just for the specific report.

[tristanvuong2021]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jcorilla)

[Marco-Premier]

Reviewed 1 of 3 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jcorilla, @riemanli, and @stevenwarejones)

---

src/main/kotlin/org/wfanet/measurement/reporting/service/api/v2alpha/ReportsService.kt line 718 at r3 (raw file):

  val isValidPageSize =
    source.pageSize != 0 && source.pageSize >= MIN_PAGE_SIZE && source.pageSize <= MAX_PAGE_SIZE

nit this could be simplified: source.pageSize in 1..MAX_PAGE_SIZE

Code quote:

source.pageSize != 0 && source.pageSize >= MIN_PAGE_SIZE && source.pageSize <= MAX_PAGE_SIZE

[riemanli]

Reviewable status: 2 of 4 files reviewed, all discussions resolved (waiting on @jcorilla, @Marco-Premier, @stevenwarejones, and @tristanvuong2021)

---

src/main/kotlin/org/wfanet/measurement/reporting/service/api/v2alpha/ReportsService.kt line 718 at r3 (raw file):

Previously, Marco-Premier (marcopremier) wrote…

nit this could be simplified: source.pageSize in 1..MAX_PAGE_SIZE

Thanks for the suggestion! Done.

[tristanvuong2021]

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jcorilla, @Marco-Premier, and @stevenwarejones)

[Marco-Premier]

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jcorilla and @stevenwarejones)