Put ErrorInfo in Status details instead of trailers. #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
SanjayVas
force-pushed
the
sanjayvas-error-details
branch
from
9e88ffc to
d5e60da
Compare
SanjayVas
force-pushed
the
sanjayvas-measurement-parent
branch
from
507a572 to
46f3306
Compare
renjiezh
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Reviewed 34 of 34 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
SanjayVas
force-pushed
the
sanjayvas-error-details
branch
from
d5e60da to
1f4c524
Compare
SanjayVas
force-pushed
the
sanjayvas-error-details
branch
from
1f4c524 to
485a062
Compare
stevenwarejones
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
Reviewed 31 of 34 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:
SanjayVas
force-pushed
the
sanjayvas-measurement-parent
branch
from
46f3306 to
8c76d38
Compare
SanjayVas
force-pushed
the
sanjayvas-error-details
branch
2 times, most recently
from
0feeed2 to
a04b6c7
Compare
SanjayVas
force-pushed
the
sanjayvas-measurement-parent
branch
from
8c76d38 to
5aab5eb
Compare
stevenwarejones
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
Reviewed 2 of 34 files at r1, 2 of 2 files at r3, all commit messages.
Reviewable status:
SanjayVas
force-pushed
the
sanjayvas-error-details
branch
from
a04b6c7 to
0bcc4e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.