Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cross-media-measurement-api to v0.33.0. #1024

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

SanjayVas
Copy link
Member

@SanjayVas SanjayVas commented May 24, 2023

This is a breaking change to the public API for CreateMeasurement.

https://rally1.rallydev.com/#/?detail=/task/702042750337&fdp=true

@wfa-reviewable
Copy link

This change is Reviewable

@SanjayVas SanjayVas force-pushed the sanjayvas-measurement-parent branch from d054d66 to f1b1f46 Compare May 24, 2023 16:13
@SanjayVas SanjayVas force-pushed the sanjayvas-request-id branch from 6c4025c to bca7e32 Compare May 24, 2023 19:35
@SanjayVas SanjayVas force-pushed the sanjayvas-measurement-parent branch 3 times, most recently from 7a087fb to acc05a6 Compare May 25, 2023 19:42
@SanjayVas SanjayVas force-pushed the sanjayvas-request-id branch from 3300879 to 8324a9d Compare May 25, 2023 19:42
@SanjayVas SanjayVas force-pushed the sanjayvas-measurement-parent branch from acc05a6 to f2d19d6 Compare May 25, 2023 19:55
@SanjayVas SanjayVas changed the base branch from sanjayvas-request-id to sanjayvas-exchange-party May 25, 2023 19:57
@SanjayVas
Copy link
Member Author

@SanjayVas SanjayVas force-pushed the sanjayvas-measurement-parent branch 2 times, most recently from 507a572 to 46f3306 Compare June 1, 2023 21:04
@SanjayVas SanjayVas force-pushed the sanjayvas-exchange-party branch from 35d84e7 to 38fb66f Compare June 1, 2023 21:04
@SanjayVas SanjayVas changed the title Update cross-media-measurement-api. Update cross-media-measurement-api to v0.33.0. Jun 1, 2023
@SanjayVas SanjayVas marked this pull request as ready for review June 1, 2023 21:06
@SanjayVas SanjayVas requested a review from stevenwarejones June 1, 2023 21:06
Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas SanjayVas changed the base branch from sanjayvas-exchange-party to main June 5, 2023 16:14
@SanjayVas SanjayVas force-pushed the sanjayvas-measurement-parent branch from 46f3306 to 8c76d38 Compare June 5, 2023 16:18
This is a breaking change to the public API.
@SanjayVas SanjayVas force-pushed the sanjayvas-measurement-parent branch from 8c76d38 to 5aab5eb Compare June 5, 2023 16:27
Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas SanjayVas enabled auto-merge (squash) June 5, 2023 16:29
@SanjayVas SanjayVas merged commit 336006a into main Jun 5, 2023
@SanjayVas SanjayVas deleted the sanjayvas-measurement-parent branch June 5, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants