-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GetReportByRequestId. #1007
Add GetReportByRequestId. #1007
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jcorilla and @riemanli)
a discussion (no related file):
Is this necessary? CreateReport can return the existing report if one is found with the same request id.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @riemanli)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tristanvuong2021)
a discussion (no related file):
Previously, tristanvuong2021 (Tristan Vuong) wrote…
Is this necessary? CreateReport can return the existing report if one is found with the same request id.
You're right. I thought I could save some computation before calling internal CreateReport
by using GetReportByRequestId
, but it turned out there is not much to save. I will close this PR.
No description provided.