Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetReportByRequestId. #1007

Conversation

riemanli
Copy link
Contributor

No description provided.

@wfa-reviewable
Copy link

This change is Reviewable

@riemanli
Copy link
Contributor Author

riemanli commented May 16, 2023

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@riemanli riemanli mentioned this pull request May 16, 2023
Copy link
Contributor

@tristanvuong2021 tristanvuong2021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jcorilla and @riemanli)

a discussion (no related file):
Is this necessary? CreateReport can return the existing report if one is found with the same request id.


Copy link
Contributor

@jcorilla jcorilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @riemanli)

Copy link
Contributor Author

@riemanli riemanli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tristanvuong2021)

a discussion (no related file):

Previously, tristanvuong2021 (Tristan Vuong) wrote…

Is this necessary? CreateReport can return the existing report if one is found with the same request id.

You're right. I thought I could save some computation before calling internal CreateReport by using GetReportByRequestId, but it turned out there is not much to save. I will close this PR.


@riemanli riemanli closed this May 17, 2023
@riemanli riemanli mentioned this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants