Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow use of custom metadata descriptors in EDP simulator #1880

Closed
SanjayVas opened this issue Oct 28, 2024 · 2 comments · Fixed by #1886
Closed

Allow use of custom metadata descriptors in EDP simulator #1880

SanjayVas opened this issue Oct 28, 2024 · 2 comments · Fixed by #1886
Assignees
Labels
enhancement New feature or request

Comments

@SanjayVas
Copy link
Member

Background

The primary intent of the EDP simulator is to facilitate Halo integration tests. It is however also useful for operators of Halo systems to use it for their own testing, so some functionality has been added to support this. The EDP simulator currently uses specific EventGroup metadata descriptors to control requisition fulfillment behavior w.r.t. how events are generated. The intent was that real EDPs could also be made to implement the same behavior to support conformance testing. With the advent of efforts such as HMSS, EDP libraries, and the EDP aggregator, the need for this kind of performance testing has diminished. Separately, Halo operators have indicated a desire to use the EDP simulator for end-to-end testing of other parts of their systems such as EventGroup search.

Proposal

Allow operators to specify EventGroup metadata using any EventGroup metadata descriptor. This means that the metadata descriptor cannot be used to control event generation behavior. Instead, this behavior is solely controlled via configuration of the simulator itself.

@SanjayVas SanjayVas added the enhancement New feature or request label Oct 28, 2024
@SanjayVas SanjayVas self-assigned this Oct 28, 2024
@SanjayVas
Copy link
Member Author

Note that no two registered EventGroup metadata descriptors can share types unless those types are in the "known event group metadata type" set. This is controlled by the --known-event-group-metadata-type option passed to the Kingdom and Reporting systems. See the v0.5.2 release notes for more details.

@SanjayVas
Copy link
Member Author

SanjayVas commented Oct 28, 2024

It'll be easier to implement this after first doing #1881

SanjayVas added a commit that referenced this issue Oct 30, 2024
…tion (#1886)

EventGroup metadata is now supplied by the `--event-group-metadata` option instead of using the specs passed to the `--event-group-spec` option. The `--event-group-metadata-type-url` option is used to indicate the message type of the EventGroup metadata, which must be a known metadata type.

BREAKING CHANGE: The EDP simulator has a new required `--event-group-metadata` option.
BREAKING CHANGE: The EDP simulator now takes the `--known-event-group-metadata-type` option.

Closes #1880
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
1 participant