Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfirmComputationParticipant checks status of non-participant Duchies #1269

Closed
uakyol opened this issue Oct 3, 2023 · 0 comments · Fixed by #1272
Closed

ConfirmComputationParticipant checks status of non-participant Duchies #1269

uakyol opened this issue Oct 3, 2023 · 0 comments · Fixed by #1272
Assignees
@Marco-Premier
Labels
bug Something isn't working

Comments

@uakyol
Copy link
Contributor

uakyol commented Oct 3, 2023 •
edited by SanjayVas
Loading

Describe the bug
ConfirmComputationParticipant checks if the other Duchy participants are in the desired state. This does not actually use the Duchy IDs of ComputationParticipants associated with that Computation, but instead the IDs of all other configured Duchies. This may include Duchies that are not participants of that Computation, including ones that may not even be active.

Steps to reproduce

  1. Set the active end time of a duchy in the duchy id config to past
  2. Create a measurement and let the EDPs fulfill
  3. Observe that the computation for the measurement fails with wfa.measurement.internal.kingdom.ComputationParticipants ConfirmComputationParticipant

Component(s) affected
Kingdom

Version
HEAD, 0.4.0, 0.3.0
@uakyol uakyol added the bug Something isn't working label Oct 3, 2023
@SanjayVas SanjayVas changed the title ConfirmComputationParticipant checks DuchyIds that includes non active duchies ConfirmComputationParticipant checks status of non-participant Duchies Oct 3, 2023
@Marco-Premier Marco-Premier mentioned this issue Oct 4, 2023
Merged
Marco-Premier added a commit that referenced this issue Oct 11, 2023
@Marco-Premier
Marcopremier fix confirmcomputationparticipant (#1272)
192c5ee 
PR to solve issue #1269

---------

Co-authored-by: marcopremier <[email protected]>
SanjayVas pushed a commit that referenced this issue Oct 11, 2023
@Marco-Premier
Marcopremier fix confirmcomputationparticipant (#1272)
68882e3 
PR to solve issue #1269

---------

Co-authored-by: marcopremier <[email protected]>

(cherry picked from commit 192c5ee)
SanjayVas pushed a commit that referenced this issue Oct 11, 2023
@Marco-Premier
Marcopremier fix confirmcomputationparticipant (#1272)
fd8fe88 
PR to solve issue #1269

---------

Co-authored-by: marcopremier <[email protected]>

(cherry picked from commit 192c5ee)
@SanjayVas SanjayVas linked a pull request Oct 11, 2023 that will close this issue
Marcopremier fix confirmcomputationparticipant #1272
Merged
ple13 pushed a commit that referenced this issue Aug 16, 2024
@Marco-Premier @ple13
Marcopremier fix confirmcomputationparticipant (#1272)
d117903 
PR to solve issue #1269

---------

Co-authored-by: marcopremier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Marco-Premier Marco-Premier

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@Marco-Premier @SanjayVas @uakyol