Add TODO for a potential performance improvement.

world-federation-of-advertisers · May 1, 2023 · dd44a90 · dd44a90
1 parent fa8f2ce
commit dd44a90
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/src/main/kotlin/org/wfanet/measurement/reporting/service/api/v2alpha/MetricsService.kt b/src/main/kotlin/org/wfanet/measurement/reporting/service/api/v2alpha/MetricsService.kt
@@ -1015,6 +1015,10 @@ class MetricsService(
 
     return batchGetMetricsResponse {
       metrics +=
+        /**
+         * TODO(@riemanli): a potential improvement can be done by only getting the metrics whose
+         *   measurements are updated. Re-evaluate when a load-test is ready after deployment.
+         */
         if (anyMeasurementUpdated) {
           batchGetInternalMetrics(principal.resourceKey.measurementConsumerId, externalMetricIds)
             .map { it.toMetric() }
@@ -1084,8 +1088,13 @@ class MetricsService(
         principal,
       )
 
-    // If any measurement got updated, pull the list of the up-to-date internal metrics. Otherwise,
-    // use the original list.
+    /**
+     * If any measurement got updated, pull the list of the up-to-date internal metrics. Otherwise,
+     * use the original list.
+     *
+     * TODO(@riemanli): a potential improvement can be done by only getting the metrics whose
+     *   measurements are updated. Re-evaluate when a load-test is ready after deployment.
+     */
     val internalMetrics: List<InternalMetric> =
       if (anyMeasurementUpdated) {
         batchGetInternalMetrics(