feat: Add create_time to internal Requisition parent_measurement (#1851)

feature: Add create_time to internal Requisition parent_measurement
world-federation-of-advertisers · Oct 11, 2024 · dc1dfe3 · dc1dfe3
1 parent a30679f
commit dc1dfe3
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 0 deletions.
diff --git a/.../kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/readers/RequisitionReader.kt b/.../kotlin/org/wfanet/measurement/kingdom/deploy/gcloud/spanner/readers/RequisitionReader.kt
@@ -151,6 +151,7 @@ class RequisitionReader : SpannerReader<RequisitionReader.Result>() {
           ExternalMeasurementId,
           ExternalDataProviderId,
           Measurements.State AS MeasurementState,
+          CreateTime,
           ExternalComputationId,
           CertificateId,
           MeasurementDetails
@@ -185,6 +186,7 @@ class RequisitionReader : SpannerReader<RequisitionReader.Result>() {
     CertificateDetails,
     MeasurementState,
     MeasurementDetails,
+    FilteredRequisitions.CreateTime,
     (
       SELECT
         count(ExternalDataProviderId),
@@ -308,6 +310,7 @@ class RequisitionReader : SpannerReader<RequisitionReader.Result>() {
       protocolConfig = measurementDetails.protocolConfig
       state = struct.getProtoEnum("MeasurementState", Measurement.State::forNumber)
       dataProvidersCount = dataProviderCount
+      createTime = struct.getTimestamp("CreateTime").toProto()
     }
   }
 }
diff --git a/...kotlin/org/wfanet/measurement/kingdom/service/internal/testing/MeasurementsServiceTest.kt b/...kotlin/org/wfanet/measurement/kingdom/service/internal/testing/MeasurementsServiceTest.kt
@@ -971,6 +971,7 @@ abstract class MeasurementsServiceTest<T : MeasurementsCoroutineImplBase> {
                 liquidLegionsV2 = ProtocolConfig.LiquidLegionsV2.getDefaultInstance()
               }
               dataProvidersCount = 1
+              createTime = createdMeasurement.createTime
             }
             details = requisitionDetails {
               dataProviderPublicKey = dataProviderValue.dataProviderPublicKey

diff --git a/...kotlin/org/wfanet/measurement/kingdom/service/internal/testing/RequisitionsServiceTest.kt b/...kotlin/org/wfanet/measurement/kingdom/service/internal/testing/RequisitionsServiceTest.kt
@@ -586,6 +586,7 @@ abstract class RequisitionsServiceTest<T : RequisitionsCoroutineService> {
           liquidLegionsV2 = ProtocolConfig.LiquidLegionsV2.getDefaultInstance()
         }
         dataProvidersCount = 1
+        createTime = measurement.createTime
       }
     }
     assertThat(requisition)
@@ -667,6 +668,7 @@ abstract class RequisitionsServiceTest<T : RequisitionsCoroutineService> {
         state = Measurement.State.PENDING_REQUISITION_FULFILLMENT
         protocolConfig = protocolConfig { direct = ProtocolConfig.Direct.getDefaultInstance() }
         dataProvidersCount = 1
+        createTime = measurement.createTime
       }
     }
     assertThat(requisition)

diff --git a/src/main/proto/wfa/measurement/internal/kingdom/measurement.proto b/src/main/proto/wfa/measurement/internal/kingdom/measurement.proto
@@ -202,6 +202,8 @@ message Requisition {
     Measurement.State state = 6;
 
     int32 data_providers_count = 7;
+
+    google.protobuf.Timestamp create_time = 9;
   }
   // Denormalized fields from the parent Measurement. Output-only.
   ParentMeasurement parent_measurement = 12;