fix!: Update maximum and default page_size for ListRequisitions and L…

…istEventGroups (#1916) Closes #1915
world-federation-of-advertisers · Nov 18, 2024 · 6f9b14b · 6f9b14b
1 parent cb75127
commit 6f9b14b
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 10 deletions.
diff --git a/MODULE.bazel b/MODULE.bazel
@@ -47,7 +47,7 @@ bazel_dep(
 )
 bazel_dep(
     name = "cross-media-measurement-api",
-    version = "0.69.0",
+    version = "0.70.0",
     repo_name = "wfa_measurement_proto",
 )
 bazel_dep(

diff --git a/MODULE.bazel.lock b/MODULE.bazel.lock
diff --git a/src/main/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/EventGroupsService.kt b/src/main/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/EventGroupsService.kt
@@ -450,8 +450,8 @@ class EventGroupsService(private val internalEventGroupsStub: InternalEventGroup
   }
 
   companion object {
-    private const val DEFAULT_PAGE_SIZE = 50
-    private const val MAX_PAGE_SIZE = 1000
+    private const val DEFAULT_PAGE_SIZE = 10
+    private const val MAX_PAGE_SIZE = 500
   }
 }
 

diff --git a/src/main/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/RequisitionsService.kt b/src/main/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/RequisitionsService.kt
@@ -82,8 +82,8 @@ import org.wfanet.measurement.internal.kingdom.refuseRequisitionRequest
 import org.wfanet.measurement.internal.kingdom.requisitionRefusal as internalRequisitionRefusal
 import org.wfanet.measurement.internal.kingdom.streamRequisitionsRequest
 
-private const val DEFAULT_PAGE_SIZE = 50
-private const val MAX_PAGE_SIZE = 1000
+private const val DEFAULT_PAGE_SIZE = 10
+private const val MAX_PAGE_SIZE = 500
 
 class RequisitionsService(private val internalRequisitionStub: RequisitionsCoroutineStub) :
   RequisitionsCoroutineImplBase() {

diff --git a/src/test/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/EventGroupsServiceTest.kt b/src/test/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/EventGroupsServiceTest.kt
@@ -1128,7 +1128,7 @@ class EventGroupsServiceTest {
     }
     assertThat(streamEventGroupsRequest)
       .comparingExpectedFieldsOnly()
-      .isEqualTo(streamEventGroupsRequest { limit = 51 })
+      .isEqualTo(streamEventGroupsRequest { limit = 11 })
   }
 
   @Test

diff --git a/...test/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/RequisitionsServiceTest.kt b/...test/kotlin/org/wfanet/measurement/kingdom/service/api/v2alpha/RequisitionsServiceTest.kt
@@ -127,7 +127,7 @@ import org.wfanet.measurement.kingdom.deploy.gcloud.spanner.common.RequisitionSt
 
 private val UPDATE_TIME: Timestamp = Instant.ofEpochSecond(123).toProtoTime()
 
-private const val DEFAULT_LIMIT = 50
+private const val DEFAULT_LIMIT = 10
 
 private const val WILDCARD_NAME = "dataProviders/-"