-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add create and update time to Measurement #216
Conversation
131a2ef
to
beb3e95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @roaminggypsy and @stevenwarejones)
src/main/proto/wfa/measurement/api/v2alpha/measurement.proto
line 365 at r1 (raw file):
[(google.api.field_behavior) = OUTPUT_ONLY]; // When the 'Measurement' was lastly updated.
Suggestion:
last
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @SanjayVas and @stevenwarejones)
src/main/proto/wfa/measurement/api/v2alpha/measurement.proto
line 365 at r1 (raw file):
[(google.api.field_behavior) = OUTPUT_ONLY]; // When the 'Measurement' was lastly updated.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @stevenwarejones)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised we didn't already have these.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @roaminggypsy)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah. I was hesitating whether I can add these fields because I thought there were intentionally not exposed. It turned out that it is just because previous work did not need such fields.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @roaminggypsy)
Make it easier to filter Measurements for prober