Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation for TimeInterval #154

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

Marco-Premier
Copy link
Contributor

  • Update documentation for TimeInterval
  • Add oneof type to ModelRollout

@wfa-reviewable
Copy link

This change is Reviewable

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jojijac0b and @Marco-Premier)


src/main/proto/wfa/measurement/api/v2alpha/model_rollout.proto line 47 at r1 (raw file):

    // 'end_time' cannot precede 'start_time'.
    TimeInterval gradual_rollout_period = 8 [
      (google.api.field_behavior) = REQUIRED,

This field itself is not required. Rather, the oneof itself is required. (There is no way to document this with an annotation. Just use a regular comment on the oneof field.

Code quote:

(google.api.field_behavior) = REQUIRED,

Copy link
Contributor Author

@Marco-Premier Marco-Premier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @jojijac0b and @SanjayVas)


src/main/proto/wfa/measurement/api/v2alpha/model_rollout.proto line 47 at r1 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

This field itself is not required. Rather, the oneof itself is required. (There is no way to document this with an annotation. Just use a regular comment on the oneof field.

Correct, thanks. I marked it as IMMUTABLE as well as instant_rollout_time

Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @jojijac0b)

@Marco-Premier Marco-Premier merged commit a1285a0 into main Jul 3, 2023
@Marco-Premier Marco-Premier deleted the marcopremier-add-oneof-to-model-rollout branch July 3, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants