Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a secondary EventGroup pattern with MeasurementConsumer as the parent. #148

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Add a secondary EventGroup pattern with MeasurementConsumer as the parent. #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/main/proto/wfa/measurement/api/v2alpha/event_group.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,14 @@ message EventGroup {
option (google.api.resource) = {
type: "halo.wfanet.org/EventGroup"
pattern: "dataProviders/{data_provider}/eventGroups/{event_group}"
pattern: "measurementConsumers/{measurement_consumer}/eventGroups/{event_group}"
singular: "eventGroup"
plural: "eventGroups"
};

// Resource name.
//
// Canonical format: dataProviders/{data_provider}/eventGroups/{event_group}
string name = 1;

// Resource name of the `MeasurementConsumer` associated with this
Expand Down
9 changes: 5 additions & 4 deletions src/main/proto/wfa/measurement/api/v2alpha/event_groups_service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,11 +112,9 @@ message DeleteEventGroupRequest {

// Request message for `ListEventGroups` method.
message ListEventGroupsRequest {
// Resource name of the parent `DataProvider`. The wildcard ID (`-`) may be
// used in place of the `DataProvider` ID to list across `DataProvider`s, in
// which case a filter should be specified.
// Resource name of the parent.
string parent = 1 [
(google.api.resource_reference).type = "halo.wfanet.org/DataProvider",
(google.api.resource_reference).child_type = "halo.wfanet.org/EventGroup",
(google.api.field_behavior) = REQUIRED
];

Expand All @@ -137,6 +135,9 @@ message ListEventGroupsRequest {
repeated string measurement_consumers = 1
[(google.api.resource_reference).type =
"halo.wfanet.org/MeasurementConsumer"];
// Matches against the parent `DataProvider`.
repeated string data_providers = 6
[(google.api.resource_reference).type = "halo.wfanet.org/DataProvider"];
}
// Filter criteria for this request.
//
Expand Down