Update api-linter for workflow to 1.52.0. (#147)

world-federation-of-advertisers · Jun 13, 2023 · 46b3905 · 46b3905
1 parent e7de052
commit 46b3905
Show file tree

Hide file tree

Showing 8 changed files with 2 additions and 9 deletions.
diff --git a/.github/workflows/api-lint.yml b/.github/workflows/api-lint.yml
@@ -34,7 +34,7 @@ jobs:
 
     - name: Set up api-linter
       env:
-        VERSION: 1.48.0
+        VERSION: 1.52.0
       run: |
         cd ~
         curl -L "https://github.com/googleapis/api-linter/releases/download/v${VERSION}/api-linter-${VERSION}-linux-amd64.tar.gz" -o api-linter.tar.gz

diff --git a/src/main/proto/api-linter.yaml b/src/main/proto/api-linter.yaml
@@ -21,3 +21,4 @@
   - 'core::0146::any'
   - 'core::0133::request-id-field'
   - 'core::0121::resource-must-support-get'
+  - 'core::0203::field-behavior-required'
diff --git a/src/main/proto/wfa/measurement/api/v2alpha/certificates_service.proto b/src/main/proto/wfa/measurement/api/v2alpha/certificates_service.proto
@@ -80,7 +80,6 @@ message RevokeCertificateRequest {
   // Revocation state to set.
   //
   // (-- api-linter: core::0216::state-field-output-only=disabled
-  //     api-linter: core::0203::output-only=disabled
   //     aip.dev/not-precedent: This is not a resource state field. --)
   Certificate.RevocationState revocation_state = 2
       [(google.api.field_behavior) = REQUIRED];

diff --git a/src/main/proto/wfa/measurement/api/v2alpha/exchange_step_attempts_service.proto b/src/main/proto/wfa/measurement/api/v2alpha/exchange_step_attempts_service.proto
@@ -67,7 +67,6 @@ message FinishExchangeStepAttemptRequest {
 
   // The ultimate state of the `ExchangeStepAttempt`. Must be a terminal state.
   // (-- api-linter: core::0216::state-field-output-only=disabled
-  //     api-linter: core::0203::output-only=disabled
   //     aip.dev/not-precedent: This is not a resource state field. --)
   ExchangeStepAttempt.State final_state = 2
       [(google.api.field_behavior) = REQUIRED];

diff --git a/src/main/proto/wfa/measurement/api/v2alpha/exchange_steps_service.proto b/src/main/proto/wfa/measurement/api/v2alpha/exchange_steps_service.proto
@@ -99,7 +99,6 @@ message ListExchangeStepsRequest {
     // Matches against the `state` field.
     //
     // (-- api-linter: core::0216::state-field-output-only=disabled
-    //     api-linter: core::0203::output-only=disabled
     //     aip.dev/not-precedent: This is not a resource state field. --)
     repeated ExchangeStep.State states = 2;
     // Matches against the `event_data_provider` field of the ancestor

diff --git a/src/main/proto/wfa/measurement/api/v2alpha/exchange_workflow.proto b/src/main/proto/wfa/measurement/api/v2alpha/exchange_workflow.proto
@@ -161,8 +161,6 @@ message ExchangeWorkflow {
       int32 shard_count = 4;
       int32 buckets_per_shard = 5;
       // (-- TODO: Consider making this optional once its not experimental. --)
-      // (-- api-linter: core::0203::optional=disabled
-      //     aip.dev/not-precedent: Linter incorrectly identifies this. --)
       int32 queries_per_shard = 6;
       bool add_padding_queries = 7;
     }

diff --git a/src/main/proto/wfa/measurement/api/v2alpha/measurements_service.proto b/src/main/proto/wfa/measurement/api/v2alpha/measurements_service.proto
@@ -107,7 +107,6 @@ message ListMeasurementsRequest {
     // Matches against the `state` field.
     //
     // (-- api-linter: core::0216::state-field-output-only=disabled
-    //     api-linter: core::0203::output-only=disabled
     //     aip.dev/not-precedent: This is not a resource state field. --)
     repeated Measurement.State states = 1;
   }

diff --git a/src/main/proto/wfa/measurement/api/v2alpha/requisitions_service.proto b/src/main/proto/wfa/measurement/api/v2alpha/requisitions_service.proto
@@ -78,7 +78,6 @@ message ListRequisitionsRequest {
     // Matches against the `state` field.
     //
     // (-- api-linter: core::0216::state-field-output-only=disabled
-    //     api-linter: core::0203::output-only=disabled
     //     aip.dev/not-precedent: This is not a resource state field. --)
     repeated Requisition.State states = 1;
     // Matches against the `measurement` field.
@@ -87,7 +86,6 @@ message ListRequisitionsRequest {
     // Matches against the `measurement_state` field.
     //
     // (-- api-linter: core::0216::state-field-output-only=disabled
-    //     api-linter: core::0203::output-only=disabled
     //     aip.dev/not-precedent: This is not a resource state field. --)
     repeated Measurement.State measurement_states = 3;
   }