Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add German translation #715

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pille1842
Copy link

Add a German translation file. Fix #714 .

Add a German translation file. Fix workshopper#714 .
@martinheidegger
Copy link
Contributor

Hello @pille1842 and thank you for your work on this! Did you notice that each exercise can be translated as well?

In every exercise folder, like in exercises/baby_steps, there are problem descriptions with the pattern problem.{lang}.md. Adding a problem.de.md would translate the exercise content.

Do you think this partial translation of some of the UI is a sufficient addition or do you want to also add translation of the exercise files?

@lukasjoc
Copy link

lukasjoc commented Oct 4, 2020

@pille1842 are you currently working on this?

additionally to adding all the exercise translations, the UI translation should also be used by adding the code de in learnyounode.js

I also noticed that the german UI translation may also need:

credits

"menu": {
    "credits": "CREDITS"
}

and a subtitle

    "subtitle": "Selektiere eine Übung und drücke Enter um zu beginnen."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add german translation
3 participants