Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update solution.js #709

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pdwarkanath
Copy link

Using reduce rather than a loop

Using reduce rather than a loop
@ccarruitero
Copy link
Contributor

Hi @pdwarkanath

Thanks for your PR.

Your changes are not passing the linter, because the semicolon.

Personally, I think the for loop could be more easy to understand for a beginner developer.

Maybe this could be added as an alternative solution in test folder. What do you think?

@pdwarkanath
Copy link
Author

@ccarruitero Sure. Should I just add this as alternate_01.js file to the test folder?

@ccarruitero
Copy link
Contributor

@pdwarkanath following the pattern used for other files there, the file should be named valid_02.js

Make sure run npm test in your local machine to ensure linter and tests are passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants