Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

German translation exercises #61

Merged
merged 17 commits into from
Aug 18, 2017
Merged

German translation exercises #61

merged 17 commits into from
Aug 18, 2017

Conversation

Maroel
Copy link
Contributor

@Maroel Maroel commented Aug 16, 2017

I'm new on GitHub and not too deep into CSS or SASS, but experienced some HTML and CSS ages ago (about 10 years ago I coded HTML). Since then on conceptual level. Translated already two english books (60 + 100 pages) into German.

@claudiopro claudiopro self-requested a review August 16, 2017 08:31
@claudiopro claudiopro self-assigned this Aug 16, 2017
@claudiopro
Copy link
Member

This is awesome, @Maroel! I'll get to review your changes later today 😃

@claudiopro
Copy link
Member

@Maroel thank you for your PR! It looks great so far 👍

There's only one missing bit left to complete. You should also translate the file https://github.com/workshopper/learn-sass/blob/master/footer.en.md. Without this file, the user will not see instructions to validate their submission, like the following:

## HINTS

  To make a Sass (SCSS) stylesheet, create a new file with a .scss extension
  and start writing SCSS. When you are done, you must run:

     $ learn-sass verify stylesheet.scss

  to proceed. Your stylesheet will be tested, a report will be generated,
  and the lesson will be marked 'completed' if you are successful.

Please create a https://github.com/workshopper/learn-sass/blob/master/footer.de.md containing the German translation of footer.en.md.

@claudiopro
Copy link
Member

Thank you so much! I'll merge now

@claudiopro claudiopro merged commit b4b4b50 into workshopper:master Aug 18, 2017
@claudiopro
Copy link
Member

Implements #60

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants