use account-view, but show that the account isn't on this chain #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm, should it even show anything at all? (buttons, etc) Seems weird to have the 'template' but nothing populating it if it can't be interacted with |
|
yes, i changed it to show the buttons so you can airdrop (or transfer) to it. - and explicitly showing that the thing the user clicked on is not on chain yet (or anymore) is useful |
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
SvenDowideit
force-pushed
the
fix/show-airdrop-and-transfer-for-zero-balance-account-view
branch
from
a8687d8 to
a7d9239
Compare
Signed-off-by: Sven Dowideit <[email protected]>
|
ok right, the accounts will be created when they are included as part of an instruction such as transfer or airdrop, LGTM |
nathanleclaire
approved these changes
May 4, 2022
SvenDowideit
deleted the
fix/show-airdrop-and-transfer-for-zero-balance-account-view
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sven Dowideit [email protected]
Closes #95