Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile build + docker run args #72

Merged
merged 4 commits into from
Apr 6, 2022

Conversation

nathanleclaire
Copy link
Contributor

Trying to fix #26 and #45 as well as consolidate Docker image build from bespoke manual way I've done it previously

@nathanleclaire
Copy link
Contributor Author

to build the image from the root dir:

$ cd docker/solana && docker build -t cryptoworkbench/solana .


RUN rustup toolchain install nightly && rustup default nightly && rustup component add rustfmt
RUN apt-get update && apt-get install -y git pkg-config libudev-dev make libclang-dev clang
ENV SOLANA_VERSION v1.8.16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.8? booooooo :D

@nathanleclaire
Copy link
Contributor Author

This still doesn't work with solana program deploy from your local Mac unfortunately but I wanted to get it up

Copy link
Member

@SvenDowideit SvenDowideit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this as a major improvement that we can build on for the next release

so LGTM

@SvenDowideit SvenDowideit merged commit 3704a8e into main Apr 6, 2022
@SvenDowideit SvenDowideit deleted the validator_docker_run_args branch April 6, 2022 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't deploy programs to the localnet validator started by workbench
2 participants