Add config table and analytics opt out on first load #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanleclaire
force-pushed
the
analytics_opt_out
branch
from
0dc6b28 to
fa658c1
Compare
nathanleclaire
force-pushed
the
analytics_opt_out
branch
from
fa658c1 to
0904a39
Compare
nathanleclaire
commented
Mar 10, 2022
| @@ -83,7 +83,6 @@ async function accounts(msg: AccountsRequest): Promise<AccountsResponse> { | |||
| await addKeypair(KEY_PATH); | |||
| } | |||
| const kp = await localKeypair(KEY_PATH); | |||
| logger.info('accounts', { net, pubKey: kp.publicKey }); | |||
There was a problem hiding this comment.
not relevant to PR but I don't think this adds much any more
nathanleclaire
force-pushed
the
analytics_opt_out
branch
from
0904a39 to
feeb7a3
Compare
|
such privacy |
|
I don't know what "Start" means - is that the "ok" button? I'm confused as to why there are 3 buttons on this page - can the toggle use a more standard UI for toggling? |
Y, I can change to "OK"
reached for react bootstrap cause it was right there, but maybe over complicated, perhaps just a checkbox will do |
|
ah womp, 'switch' component was what i actually wanted to start and i didn't know that's what it was called |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the last thing I wanted to get done before open sourcing. Users should be aware of analytics and able to opt out.