Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a page that shows the network's version infos #37

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

SvenDowideit
Copy link
Member

@SvenDowideit SvenDowideit commented Mar 8, 2022

I wanted to know what the versions were - took quite a bit of reading to get to where this is - and I don't know if its the right way to make it work, but its a start

image

@SvenDowideit SvenDowideit force-pushed the working-out-how-to-show-node-info branch 3 times, most recently from cd3fdc5 to 37871e9 Compare March 14, 2022 07:52
@SvenDowideit SvenDowideit changed the title [WIP] figuring out how to add a page that shows the network's version infos Add a page that shows the network's version infos Mar 14, 2022
@nathanleclaire
Copy link
Contributor

Nice! This is giving me vibes of having a full blown "Network" page at some point. Showing service map with info about validators region, latency, stake, etc. Since we use faNetworkWired in the net toggle dropdown, I wonder if that icon would be good to use for this subsection of the app.

@nathanleclaire
Copy link
Contributor

So, I do wonder what role this has in a world where https://solanabeach.io/validators exists. Any thoughts?

@SvenDowideit
Copy link
Member Author

So one of the problems I want to solve, is that there's one place to get all the info - atm, its all scattered on different sites, and until you're in the know - and remember what the url is, the new dev has no idea what info is available to them.
Mind you, it would be excellent to not only give the info, but to link to those sites.

@SvenDowideit SvenDowideit force-pushed the working-out-how-to-show-node-info branch from 37871e9 to 27a3b5d Compare March 15, 2022 00:45
@nathanleclaire
Copy link
Contributor

Roger, that checks out

src/main/main.ts Outdated Show resolved Hide resolved
@SvenDowideit SvenDowideit force-pushed the working-out-how-to-show-node-info branch from 0918ed1 to c6a8253 Compare March 15, 2022 05:54
src/renderer/nav/VersionInfo.tsx Outdated Show resolved Hide resolved
src/renderer/nav/VersionInfo.tsx Outdated Show resolved Hide resolved
@nathanleclaire
Copy link
Contributor

also needs prettying and there's a few versionInfo still there would like 'em to be validatorVersionInfo

@SvenDowideit SvenDowideit force-pushed the working-out-how-to-show-node-info branch 3 times, most recently from 84c1472 to 725d8ef Compare March 17, 2022 01:08
Copy link
Contributor

@nathanleclaire nathanleclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Just a couple final nits and LGTM

src/main/validatorNetworkInfo.ts Outdated Show resolved Hide resolved
src/renderer/App.tsx Outdated Show resolved Hide resolved
@SvenDowideit SvenDowideit force-pushed the working-out-how-to-show-node-info branch from 725d8ef to 95012e0 Compare March 17, 2022 01:42
@SvenDowideit SvenDowideit merged commit c5f8e52 into main Mar 17, 2022
@SvenDowideit SvenDowideit deleted the working-out-how-to-show-node-info branch March 17, 2022 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants