-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for streaming transaction logs #31
Conversation
c513a42
to
e42eb61
Compare
logs2.movadded support for other nets, nice and twitchy with those :P |
I feel like this is unquestionably an improvement over program changes if we can make it palatable for the higher nets. Some things I'd probably like to do, like parse out the program IDs and send them to the DB so we can start building a list of programs that we can display to the user (and start the basis for the Workbench 'understanding' relationships between things) |
grin - I'm questioning it - mostly cos i don't know where i'd use it this way, and it feels weird to mix an accounts list with a raw log if i wasn't so braindead, i'd be building a dapp to figure out what i want - but i can barely complete this comment without having a nap in the middle :( |
Yea I think the txn log might be much more useful to parse a list of needed information like what programs are getting invoked |
I wonder if we can convince solana to use structured logging - its often something that devs havn't considered until someone asks :) |
can we have this as another tab on the changes page ? atm, we're basically exploring what's possible - and it might be good to compare and contrast. |
e42eb61
to
7eef55a
Compare
Done! This is pretty much ready to go now. |
@@ -150,6 +150,13 @@ export interface ChangeSubscriptionMap { | |||
}; | |||
} | |||
|
|||
export interface LogSubscriptionMap { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is only used in the one file, so doesn't need to become global
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - I'll poke types/type.ts in a refactoring PR anyway
soltxnlogs.mov