Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for streaming transaction logs #31

Merged
merged 4 commits into from
Mar 23, 2022
Merged

Conversation

nathanleclaire
Copy link
Contributor

@nathanleclaire nathanleclaire commented Mar 3, 2022

soltxnlogs.mov

@nathanleclaire nathanleclaire changed the title Start txn logs prototype [nomerge] Start txn logs prototype Mar 3, 2022
@nathanleclaire
Copy link
Contributor Author

logs2.mov

added support for other nets, nice and twitchy with those :P

@nathanleclaire
Copy link
Contributor Author

nathanleclaire commented Mar 8, 2022

I feel like this is unquestionably an improvement over program changes if we can make it palatable for the higher nets. Some things I'd probably like to do, like parse out the program IDs and send them to the DB so we can start building a list of programs that we can display to the user (and start the basis for the Workbench 'understanding' relationships between things)

@SvenDowideit
Copy link
Member

grin - I'm questioning it - mostly cos i don't know where i'd use it this way, and it feels weird to mix an accounts list with a raw log

if i wasn't so braindead, i'd be building a dapp to figure out what i want - but i can barely complete this comment without having a nap in the middle :(

@nathanleclaire
Copy link
Contributor Author

Yea I think the txn log might be much more useful to parse a list of needed information like what programs are getting invoked

@SvenDowideit
Copy link
Member

I wonder if we can convince solana to use structured logging - its often something that devs havn't considered until someone asks :)

@SvenDowideit
Copy link
Member

can we have this as another tab on the changes page ?

atm, we're basically exploring what's possible - and it might be good to compare and contrast.

@nathanleclaire
Copy link
Contributor Author

can we have this as another tab on the changes page ?

Done! This is pretty much ready to go now.

@nathanleclaire
Copy link
Contributor Author

image

@nathanleclaire nathanleclaire changed the title [nomerge] Start txn logs prototype Add support for streaming transaction logs Mar 23, 2022
@@ -150,6 +150,13 @@ export interface ChangeSubscriptionMap {
};
}

export interface LogSubscriptionMap {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is only used in the one file, so doesn't need to become global

Copy link
Member

@SvenDowideit SvenDowideit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I'll poke types/type.ts in a refactoring PR anyway

@SvenDowideit SvenDowideit merged commit 4722889 into main Mar 23, 2022
@SvenDowideit SvenDowideit deleted the program_logs branch March 23, 2022 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants