Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve validator state display #256

Merged
merged 1 commit into from
Jul 19, 2022
Merged

Conversation

nathanleclaire
Copy link
Contributor

Closes #237
Closes #195

I also changed the icon to a more gentle IconMdiBrodcastOff because ... we can't connect to the network, but that's not really something we need to WARN ⚠️ you about.

I also want to simplify view in this state a bit, as there's no real sense in showing account data when we know none exists.

Signed-off-by: Nathan LeClaire [email protected]

@nathanleclaire nathanleclaire changed the title Improve validator state display [WIP] Improve validator state display Jul 18, 2022
@nathanleclaire nathanleclaire added this to the 0.4.0 milestone Jul 18, 2022
@nathanleclaire
Copy link
Contributor Author

nathanleclaire commented Jul 18, 2022

OK yea I like this, nice and muted when nothing is happening, but no confusing layout changes. Highlights the most important thing on the page.

Screen Shot 2022-07-18 at 5 55 05 PM

@nathanleclaire
Copy link
Contributor Author

Side note, our links don't really display as links any more. :| Seems to be because of the text-decoration: inherit set on <a>. I had to use underline class from Tailwind.

Signed-off-by: Nathan LeClaire <[email protected]>
Copy link
Member

@SvenDowideit SvenDowideit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, LGTM

@nathanleclaire nathanleclaire changed the title [WIP] Improve validator state display Improve validator state display Jul 19, 2022
@nathanleclaire nathanleclaire merged commit c518911 into main Jul 19, 2022
@nathanleclaire nathanleclaire deleted the run_validator_prompt branch July 19, 2022 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants