Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify config storage IPC code #126

Merged
merged 6 commits into from
May 19, 2022

Conversation

SvenDowideit
Copy link
Member

@SvenDowideit SvenDowideit commented May 18, 2022

Ok, so my goal for this was to be able to add a new redux Slice that talks to its counterpart in the main process (in this case to save the values) while having all the code for that interaction only in the 2 files that deal with it.

This will make it easier to make experiments, and add other interactions - as there won't be a need to also add entries to 3 case statements.

I'm not going to deal with the other IPC calls atm, I want to use this to bring back more of the account saving code.

(ignore the file deletions - they're code that was commented out weeks ago, that I fell over as I was redoing this)

@SvenDowideit SvenDowideit changed the title Try/simplify config storage attempt Simplify config storage IPC code May 18, 2022
@SvenDowideit SvenDowideit added this to the 0.4.0 milestone May 18, 2022
@SvenDowideit
Copy link
Member Author

SvenDowideit commented May 18, 2022

@nathanleclaire and as extra ARGH! when I run npm run lint from the commandline I get no errors. I do see these in the editor, but only if i'm hunting - but there must be a reason :/

and fixing them :)

@SvenDowideit SvenDowideit force-pushed the try/simplify-config-storage-attempt3 branch from 725408d to c1be631 Compare May 18, 2022 05:32
@SvenDowideit
Copy link
Member Author

ok, merging, I'm going to use PromiseIPC for saving account info, and then we can decide how we feel about it

@SvenDowideit SvenDowideit merged commit b2b9ff7 into main May 19, 2022
@SvenDowideit SvenDowideit deleted the try/simplify-config-storage-attempt3 branch May 19, 2022 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant