Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color Settings test cases #34

Merged
merged 2 commits into from
Jun 9, 2020
Merged

Color Settings test cases #34

merged 2 commits into from
Jun 9, 2020

Conversation

lukewalczak
Copy link
Contributor

@lukewalczak lukewalczak commented Jun 9, 2020 •
edited
Loading

Test cases for complete color settings mechanism

Merge after: WordPress/gutenberg#22493

pinarol
pinarol reviewed Jun 9, 2020
View reviewed changes
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! I left some comments mostly related with visualization of the acceptance criteria. Let's try to make it easily understandable for people who are not familiar with the color palette.

test-cases/gutenberg/color-settings.md Outdated Show resolved Hide resolved
test-cases/gutenberg/color-settings.md Show resolved Hide resolved
test-cases/gutenberg/color-settings.md Show resolved Hide resolved
test-cases/gutenberg/color-settings.md Show resolved Hide resolved
test-cases/gutenberg/color-settings.md Show resolved Hide resolved
pinarol
pinarol approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@pinarol pinarol merged commit 9e441f0 into master Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinarol pinarol pinarol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukewalczak @pinarol