Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove known issue #2154 from test cases #108

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Remove known issue #2154 from test cases #108

merged 1 commit into from
Feb 2, 2022

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Feb 2, 2022

Now that the known issue "Formating buttons aren’t updated accordingly when text is deleted" #2154 is already solved, we can remove the reference from the test cases.

@fluiddot fluiddot requested a review from guarani February 2, 2022 10:16
guarani
guarani approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
To my knowledge, I've never actually performed this manual test (Gallery block) since these tests were performed by a separate team until recently. The change looks solid though, since it removes specific references to a closed issue.

@fluiddot fluiddot merged commit 5b19050 into trunk Feb 2, 2022
@fluiddot fluiddot deleted the update/remove-known-issue-2154 branch February 2, 2022 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guarani guarani guarani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fluiddot @guarani