Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Prompt to add the release tag #243

Merged
merged 1 commit into from
Feb 29, 2024
Merged

[CLI] Prompt to add the release tag #243

merged 1 commit into from
Feb 29, 2024

Conversation

jhnstn
Copy link
Member

@jhnstn jhnstn commented Jan 26, 2024

This adds a prompt before creating the release tag on Gutenberg.

The --no-tag flag still works as before but now without that flag the script will prompt to tag Gutenberg after it pushes up the release branch

Testing

Follow the Testing guide to set up the tool to use forked repos.

  • Run go run main.go release prepare gb {version} --no-tag and confirm that the rnmobile/{version} tag is not created on the forked repo
  • Run go run main.go release prepare gb {version} and cancel the prompt to tag the release. Confirm that the tag is not created on the forked repo
  • Run go run main.go release prepare gb {version} and confirm creating the release tag. Confirm that the tag is created on the forked repo

@jhnstn jhnstn enabled auto-merge (squash) February 7, 2024 21:29
@derekblank derekblank self-requested a review February 29, 2024 05:48
Copy link
Contributor

@derekblank derekblank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to follow the testing instructions on my forked repos. LGTM. 🚀

@jhnstn jhnstn merged commit 4347b2d into trunk Feb 29, 2024
2 checks passed
@jhnstn jhnstn deleted the update/prompt-to-tag branch February 29, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants