Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLI] Fixes for issues found durring the 1.108.0 release #223

Merged
merged 3 commits into from
Nov 15, 2023
Merged

[CLI] Fixes for issues found durring the 1.108.0 release #223

merged 3 commits into from
Nov 15, 2023

Conversation

jhnstn
Copy link
Member

@jhnstn jhnstn commented Nov 9, 2023 •
edited
Loading

  • The ios integration step failed when trying to update the config yaml file. There was a missing escaped quote.
  • Fixed the order of the org look up switch.
  • Fix --keep so it keeps the tempdir

@jhnstn jhnstn requested a review from derekblank November 9, 2023 20:23
@jhnstn jhnstn changed the title [CLI] Add missing quote [CLI] Fixes for issues found durring the 1.108.0 release Nov 10, 2023
derekblank
derekblank approved these changes Nov 12, 2023
View reviewed changes
Copy link
Contributor

@derekblank derekblank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚀

derekblank
derekblank approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@derekblank derekblank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@jhnstn jhnstn merged commit ed6bc66 into trunk Nov 15, 2023
2 checks passed
@jhnstn jhnstn deleted the fix/ios-integrate branch November 15, 2023 17:28
@jhnstn jhnstn mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekblank derekblank derekblank approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jhnstn @derekblank