[CLI] call nvm use
before each npm call on CI
#220
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing the prepare command in a Github workflow I noticed that any call to
exec.Command
seemed to run in a separate process.The result is that
nvm
needs to be ran before each npm command. Without that the workflow falls back to the default system node.Testing
The real test is to see if the changes work on a github workflow but we can test locally to make sure it's working.
Steps to check locally:
~/some-test-directory/gbm-cli
cd
into that directory and create a new empty directorygb
CI=true ../gbm-cli release prepare gb {version} --no-tag