Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 5.2.0-wp-2 #17

Merged
merged 3 commits into from
Feb 10, 2022
Merged

Update to 5.2.0-wp-2 #17

merged 3 commits into from
Feb 10, 2022

Conversation

mchowning
Copy link

@mchowning mchowning commented Feb 9, 2022

I didn't realize that we had already created a 5.2.0-wp-1 tag when I updated to that version (commit, PR). Bumping the version and rebuilding the tarball just so I can tag the merge commit from this PR with 5.2.0-wp-2 (that seemed better than moving the 5.2.0-wp-1 tag even though I don't think we're using it).

@mchowning mchowning requested a review from hypest February 9, 2022 14:50
@hypest
Copy link

hypest commented Feb 9, 2022

Shall we remove the 5.2.0-wp-1 tarball? I think that we access the tarball via the tag/hash anyway and only 1 tarball would need to be avail in the file tree?

@mchowning
Copy link
Author

mchowning commented Feb 9, 2022

Shall we remove the 5.2.0-wp-1 tarball? I think that we access the tarball via the tag/hash anyway and only 1 tarball would need to be avail in the file tree?

Thanks for catching that. Leaving it was just a miss on my part. Should be gone now.

@hypest
Copy link

hypest commented Feb 9, 2022

PR looks good to me Matt, wondering if you have a gutenberg-mobile PR to test it from, just to be sure that it can be consumed correctly?

@mchowning
Copy link
Author

Sure, the references in the gb and gb-mobile are now updated. Obviously, I'll update them again once this PR is merged and tagged.

Copy link

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Tried it locally and the video background on a cover block works fine 👍

@mchowning mchowning merged commit 9a98442 into wp-fork Feb 10, 2022
@mchowning mchowning deleted the update-to_5.2.0-wp-2 branch February 10, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants