Use react-native-cli with the Android debugging fix #840
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent upgrade to React Native 0.59 had a regression that made us lose the ability to properly debug the JS source code under Android.
This PR introduces a workaround by using the fixes version of the
react-native-cli
package, before it becomes available directly via a future React Native release.Relevant tickets: facebook/react-native#23955, facebook/metro#380
To test:
debugger;
statement somewhere in the JS code. Good examples can be theblock-holder.js
module and therender()
function ingutenberg/.../components/rich-text/index.native.js
.debugger
statements and properly showing the source file