Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated controls plugin #814

Merged
merged 1 commit into from
Apr 4, 2019
Merged

Remove deprecated controls plugin #814

merged 1 commit into from
Apr 4, 2019

Conversation

koke
Copy link
Member

@koke koke commented Apr 3, 2019

Fixes this warning:

Simulator Screen Shot - iPhone Xs - 2019-04-03 at 20 11 44

According to the warning, "The controls plugins is now baked-in."

The change was done in WordPress/gutenberg#14634 which was just brought in by merging Gutenberg master in #643.

To test:

  • Open Gutenberg and verify there are no warnings displayed

According to the warning, "The controls plugins is now baked-in."
@koke koke added the [Type] Bug Something isn't working label Apr 3, 2019
@koke koke added this to the v1.2 milestone Apr 3, 2019
@koke koke requested a review from Tug April 3, 2019 20:39
Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@koke koke merged commit 3eb3ae1 into develop Apr 4, 2019
@koke koke deleted the fix-core-data-warning branch April 4, 2019 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants