Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use different block minHeight between the platforms #664

Merged
merged 4 commits into from
Feb 24, 2019
Merged

Use different block minHeight between the platforms #664

merged 4 commits into from
Feb 24, 2019

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Feb 23, 2019 •
edited
Loading

Fixes #666

Currently, each mobile platform has different internal paddings in Aztec so, need to set different block minHeights for each platform.

Gutenberg side PR: WordPress/gutenberg#14070

To test:

  1. Run the demo app in both Android and iOS
  2. Add a paragraph block. Notice that the block placeholder is fully visible without a glitch.

@hypest
Use different block minHeight between the platforms
9c8415a 
Currently, each mobile platform has different internal paddings in Aztec
so, need to set different block minHeights for each platform.
@hypest hypest added this to the v1.0 milestone Feb 23, 2019
@hypest hypest mentioned this pull request Feb 23, 2019
Merged
5 tasks
@hypest hypest changed the base branch from develop to release/1.0.1 February 23, 2019 22:51
@hypest hypest modified the milestones: v1.0, v1.0.1 Feb 23, 2019
mzorz
mzorz approved these changes Feb 24, 2019
View reviewed changes
Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! As discussed via slack :shipit:

@hypest hypest merged commit 3f36a2a into release/1.0.1 Feb 24, 2019
@hypest hypest deleted the fix/minheight-noticeable-glitch branch February 24, 2019 19:22
@mzorz mzorz mentioned this pull request Feb 25, 2019
Merged
@hypest hypest mentioned this pull request Feb 25, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzorz mzorz mzorz approved these changes

@SergioEstevao SergioEstevao Awaiting requested review from SergioEstevao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@hypest @mzorz