Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix title padding on Android #655

Merged
merged 3 commits into from
Feb 22, 2019
Merged

Conversation

pinarol
Copy link
Contributor

@pinarol pinarol commented Feb 22, 2019

This PR separates the title padding styles of iOS and Android and removes the vertical paddings of post title on Android because Android handles the paddings on native side.

Changes reside in gutenberg PR WordPress/gutenberg#14057

@pinarol
Copy link
Contributor Author

pinarol commented Feb 22, 2019

@hypest ready for another look

@pinarol pinarol requested a review from hypest February 22, 2019 16:06
Copy link
Contributor

@hypest hypest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Let's update to the merged Gutenberg hash and we can merge this too! Edit: heh. beat me to it :)

@pinarol pinarol merged commit d0cb028 into release/1.0 Feb 22, 2019
@pinarol pinarol deleted the fix/android-title-padding branch February 22, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants