Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.105.0 #6243

Merged
merged 7 commits into from
Sep 28, 2023
Merged

Release 1.105.0 #6243

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f5bafa1
Release script: Update gb mobile version to 1.105.0
derekblank Sep 28, 2023
0126a57
Release script: Update gutenberg ref
derekblank Sep 28, 2023
5e6fc5c
Release script: Update bundle for: 1.105.0
derekblank Sep 28, 2023
25cc005
Release script: Sync XCFramework `Podfile.lock` with 1.105.0
derekblank Sep 28, 2023
e368239
Update RELEASE-NOTES
derekblank Sep 28, 2023
5ac4d8b
Add missing localization strings
fluiddot Sep 28, 2023
9473a51
Merge branch 'trunk' into release/1.105.0
fluiddot Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
Unreleased
---

1.105.0
---
* [*] Prevent crashes when setting an invalid media URL for Video or Audio blocks [https://github.com/wordpress-mobile/gutenberg-mobile/pull/6235]
* [*] Limit inner blocks nesting depth to avoid call stack size exceeded crash [https://github.com/wordpress-mobile/gutenberg-mobile/pull/6191]
* [**] Fallback to Twitter provider when embedding X URLs [https://github.com/WordPress/gutenberg/pull/54876]
Expand Down
11 changes: 10 additions & 1 deletion bundle/android/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@
<!-- translators: displays audio file extension. e.g. MP3 audio file -->
<string name="gutenberg_native_audio_file" tools:ignore="UnusedResources">audio file</string>
<string name="gutenberg_native_audio_player" tools:ignore="UnusedResources">Audio Player</string>
<string name="gutenberg_native_block_cannot_be_rendered_because_it_is_deeply_nested_tap_here_for" tools:ignore="UnusedResources">Block cannot be rendered because it is deeply nested. Tap here for more details.</string>
<!-- translators: displayed right after the block is copied. -->
<string name="gutenberg_native_block_copied" tools:ignore="UnusedResources">Block copied</string>
<!-- translators: displayed right after the block is cut. -->
Expand All @@ -65,6 +66,10 @@
<string name="gutenberg_native_blocks_allow_you_to_focus_on_writing_your_content_knowing_that_al" tools:ignore="UnusedResources">Blocks allow you to focus on writing your content, knowing that all the formatting tools you need are there to help you get your message across.</string>
<string name="gutenberg_native_blocks_are_pieces_of_content_that_you_can_insert_rearrange_and_st" tools:ignore="UnusedResources">Blocks are pieces of content that you can insert, rearrange, and style without needing to know how to code. Blocks are an easy and modern way for you to create beautiful layouts.</string>
<string name="gutenberg_native_blocks_menu" tools:ignore="UnusedResources">Blocks menu</string>
<!-- translators: Warning related to having blocks deeply nested. %d: The deepest nesting level. -->
<string name="gutenberg_native_blocks_nested_deeper_than_d_levels_may_not_render_properly_in_the" tools:ignore="UnusedResources">Blocks nested deeper than %d levels may not render properly in the mobile editor. For this reason, we recommend flattening the content by ungrouping the block or editing the block using your web browser.</string>
<!-- translators: Warning related to having blocks deeply nested. %d: The deepest nesting level. -->
<string name="gutenberg_native_blocks_nested_deeper_than_d_levels_may_not_render_properly_in_the_09df8c78" tools:ignore="UnusedResources">Blocks nested deeper than %d levels may not render properly in the mobile editor. For this reason, we recommend flattening the content by ungrouping the block or editing the block using the web editor.</string>
<string name="gutenberg_native_border_radius" tools:ignore="UnusedResources">Border Radius</string>
<string name="gutenberg_native_border_settings" tools:ignore="UnusedResources">Border Settings</string>
<string name="gutenberg_native_briefly_describe_the_link_to_help_screen_reader_user" tools:ignore="UnusedResources">Briefly describe the link to help screen reader user</string>
Expand Down Expand Up @@ -106,6 +111,7 @@
<string name="gutenberg_native_customize_blocks" tools:ignore="UnusedResources">Customize blocks</string>
<string name="gutenberg_native_customize_gradient" tools:ignore="UnusedResources">Customize Gradient</string>
<string name="gutenberg_native_cut_block" tools:ignore="UnusedResources">Cut block</string>
<string name="gutenberg_native_deeply_nested_block" tools:ignore="UnusedResources">Deeply nested block</string>
<string name="gutenberg_native_describe_the_purpose_of_the_image_leave_empty_if_decorative" tools:ignore="UnusedResources">Describe the purpose of the image. Leave empty if decorative.</string>
<string name="gutenberg_native_dismiss" tools:ignore="UnusedResources">Dismiss</string>
<string name="gutenberg_native_double_tap_and_hold_to_edit" tools:ignore="UnusedResources">Double tap and hold to edit</string>
Expand Down Expand Up @@ -348,10 +354,11 @@ translators: %s: Select control option value e.g: "Auto, 25%". -->
<string name="gutenberg_native_slash_inserter_results" tools:ignore="UnusedResources">Slash inserter results</string>
<string name="gutenberg_native_some_blocks_have_additional_settings_tap_the_settings_icon_on_the" tools:ignore="UnusedResources">Some blocks have additional settings. Tap the settings icon on the bottom right of the block to view more options.</string>
<string name="gutenberg_native_start_writing" tools:ignore="UnusedResources">Start writing…</string>
<string name="gutenberg_native_synced_patterns" tools:ignore="UnusedResources">Synced patterns</string>
<string name="gutenberg_native_take_a_photo" tools:ignore="UnusedResources">Take a Photo</string>
<string name="gutenberg_native_take_a_photo_or_video" tools:ignore="UnusedResources">Take a Photo or Video</string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curiously enough, this string is not used anywhere in the Gutenberg codebase 🤔 .

<string name="gutenberg_native_take_a_video" tools:ignore="UnusedResources">Take a Video</string>
<string name="gutenberg_native_tap_here_to_show_help" tools:ignore="UnusedResources">Tap here to show help</string>
<string name="gutenberg_native_tap_here_to_show_more_details" tools:ignore="UnusedResources">Tap here to show more details.</string>
<string name="gutenberg_native_tap_to_hide_the_keyboard" tools:ignore="UnusedResources">Tap to hide the keyboard</string>
<string name="gutenberg_native_text_color" tools:ignore="UnusedResources">Text color</string>
<string name="gutenberg_native_text_formatting_controls_are_located_within_the_toolbar_positione" tools:ignore="UnusedResources">Text formatting controls are located within the toolbar positioned above the keyboard while editing a text block</string>
Expand All @@ -368,6 +375,7 @@ translators: %s: Select control option value e.g: "Auto, 25%". -->
<string name="gutenberg_native_two" tools:ignore="UnusedResources">Two</string>
<string name="gutenberg_native_type_a_url" tools:ignore="UnusedResources">Type a URL</string>
<string name="gutenberg_native_unable_to_embed_media" tools:ignore="UnusedResources">Unable to embed media</string>
<string name="gutenberg_native_ungroup_block" tools:ignore="UnusedResources">Ungroup block</string>
<!-- translators: %s: the hex color value -->
<string name="gutenberg_native_unlabeled_color_s" tools:ignore="UnusedResources">Unlabeled color. %s</string>
<string name="gutenberg_native_unsupported" tools:ignore="UnusedResources">Unsupported</string>
Expand All @@ -380,6 +388,7 @@ translators: %s: Select control option value e.g: "Auto, 25%". -->
<string name="gutenberg_native_video_caption_empty" tools:ignore="UnusedResources">Video caption. Empty</string>
<!-- translators: accessibility text. %s: video caption. -->
<string name="gutenberg_native_video_caption_s" tools:ignore="UnusedResources">Video caption. %s</string>
<string name="gutenberg_native_warning_message" tools:ignore="UnusedResources">Warning message</string>
<string name="gutenberg_native_we_are_working_hard_to_add_more_blocks_with_each_release" tools:ignore="UnusedResources">We are working hard to add more blocks with each release.</string>
<!-- translators: %s: embed block variant's label e.g: "Twitter". -->
<string name="gutenberg_native_we_re_working_hard_on_adding_support_for_s_previews_in_the_meanti" tools:ignore="UnusedResources">We’re working hard on adding support for %s previews. In the meantime, you can preview the embedded content on the page.</string>
Expand Down
9 changes: 8 additions & 1 deletion bundle/ios/GutenbergNativeTranslations.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ private func dummy() {
_ = NSLocalizedString("Audio caption. Empty", comment: "translators: accessibility text. Empty Audio caption.")
_ = NSLocalizedString("audio file", comment: "translators: displays audio file extension. e.g. MP3 audio file")
_ = NSLocalizedString("Audio Player", comment: "")
_ = NSLocalizedString("Block cannot be rendered because it is deeply nested. Tap here for more details.", comment: "")
_ = NSLocalizedString("Block copied", comment: "translators: displayed right after the block is copied.")
_ = NSLocalizedString("Block cut", comment: "translators: displayed right after the block is cut.")
_ = NSLocalizedString("Block duplicated", comment: "translators: displayed right after the block is duplicated.")
Expand All @@ -65,6 +66,8 @@ private func dummy() {
_ = NSLocalizedString("Blocks allow you to focus on writing your content, knowing that all the formatting tools you need are there to help you get your message across.", comment: "")
_ = NSLocalizedString("Blocks are pieces of content that you can insert, rearrange, and style without needing to know how to code. Blocks are an easy and modern way for you to create beautiful layouts.", comment: "")
_ = NSLocalizedString("Blocks menu", comment: "")
_ = NSLocalizedString("Blocks nested deeper than %d levels may not render properly in the mobile editor. For this reason, we recommend flattening the content by ungrouping the block or editing the block using the web editor.", comment: "translators: Warning related to having blocks deeply nested. %d: The deepest nesting level.")
_ = NSLocalizedString("Blocks nested deeper than %d levels may not render properly in the mobile editor. For this reason, we recommend flattening the content by ungrouping the block or editing the block using your web browser.", comment: "translators: Warning related to having blocks deeply nested. %d: The deepest nesting level.")
_ = NSLocalizedString("Border Radius", comment: "")
_ = NSLocalizedString("Border Settings", comment: "")
_ = NSLocalizedString("Briefly describe the link to help screen reader user", comment: "")
Expand Down Expand Up @@ -102,6 +105,7 @@ private func dummy() {
_ = NSLocalizedString("Customize blocks", comment: "")
_ = NSLocalizedString("Customize Gradient", comment: "")
_ = NSLocalizedString("Cut block", comment: "")
_ = NSLocalizedString("Deeply nested block", comment: "")
_ = NSLocalizedString("Describe the purpose of the image. Leave empty if decorative.", comment: "")
_ = NSLocalizedString("Dismiss", comment: "")
_ = NSLocalizedString("Double tap and hold to edit", comment: "")
Expand Down Expand Up @@ -292,10 +296,11 @@ private func dummy() {
_ = NSLocalizedString("Slash inserter results", comment: "translators: Slash inserter autocomplete results")
_ = NSLocalizedString("Some blocks have additional settings. Tap the settings icon on the bottom right of the block to view more options.", comment: "")
_ = NSLocalizedString("Start writing…", comment: "")
_ = NSLocalizedString("Synced patterns", comment: "")
_ = NSLocalizedString("Take a Photo", comment: "")
_ = NSLocalizedString("Take a Photo or Video", comment: "")
_ = NSLocalizedString("Take a Video", comment: "")
_ = NSLocalizedString("Tap here to show help", comment: "")
_ = NSLocalizedString("Tap here to show more details.", comment: "")
_ = NSLocalizedString("Tap to hide the keyboard", comment: "")
_ = NSLocalizedString("Text color", comment: "")
_ = NSLocalizedString("Text formatting controls are located within the toolbar positioned above the keyboard while editing a text block", comment: "")
Expand All @@ -311,6 +316,7 @@ private func dummy() {
_ = NSLocalizedString("Two", comment: "")
_ = NSLocalizedString("Type a URL", comment: "")
_ = NSLocalizedString("Unable to embed media", comment: "")
_ = NSLocalizedString("Ungroup block", comment: "")
_ = NSLocalizedString("Unlabeled color. %s", comment: "translators: %s: the hex color value")
_ = NSLocalizedString("Unsupported", comment: "")
_ = NSLocalizedString("Updates the title.", comment: "")
Expand All @@ -320,6 +326,7 @@ private func dummy() {
_ = NSLocalizedString("Use icon button", comment: "")
_ = NSLocalizedString("Video caption. %s", comment: "translators: accessibility text. %s: video caption.")
_ = NSLocalizedString("Video caption. Empty", comment: "translators: accessibility text. Empty video caption.")
_ = NSLocalizedString("Warning message", comment: "")
_ = NSLocalizedString("We are working hard to add more blocks with each release.", comment: "")
_ = NSLocalizedString("We’re working hard on adding support for %s previews. In the meantime, you can preview the embedded content on the page.", comment: "translators: %s: embed block variant's label e.g: \"Twitter\".")
_ = NSLocalizedString("We’re working hard on adding support for %s previews. In the meantime, you can preview the embedded content on the post.", comment: "translators: %s: embed block variant's label e.g: \"Twitter\".")
Expand Down
2 changes: 1 addition & 1 deletion gutenberg
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Gutenberg reference is not pointing to the latest commit from WordPress/gutenberg#54898. However, I understand that the latest changes in the PR aren't incorporating anything critical that we'd like to check in the CI test jobs.

Submodule gutenberg updated 4 files
+1 −1 packages/react-native-aztec/package.json
+1 −1 packages/react-native-bridge/package.json
+4 −4 packages/react-native-editor/ios/Podfile.lock
+1 −1 packages/react-native-editor/package.json
4 changes: 2 additions & 2 deletions ios-xcframework/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,7 @@ PODS:
- React-RCTImage
- RNSVG (13.9.0):
- React-Core
- RNTAztecView (1.104.0):
- RNTAztecView (1.105.0):
- React-Core
- WordPress-Aztec-iOS (= 1.19.9)
- SDWebImage (5.11.1):
Expand Down Expand Up @@ -659,7 +659,7 @@ SPEC CHECKSUMS:
RNReanimated: 21e1e71d7f1ac9f2fa11df37c06a8ec52ed06232
RNScreens: e3ffdd78ff5afe8ec82c2566ee2410857ed5ce75
RNSVG: 29dd0ac32d83774d4b0953ae92a5cd8205a782d7
RNTAztecView: dfbe69cb1448f08b29846616fbb79d79f21968b3
RNTAztecView: 4b0ffdbaa58dcbf73b63403a888a2334fc4465dd
SDWebImage: a7f831e1a65eb5e285e3fb046a23fcfbf08e696d
SDWebImageWebPCoder: 908b83b6adda48effe7667cd2b7f78c897e5111d
WordPress-Aztec-iOS: fbebd569c61baa252b3f5058c0a2a9a6ada686bb
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "gutenberg-mobile",
"version": "1.104.0",
"version": "1.105.0",
"private": true,
"config": {
"jsfiles": "./*.js src/*.js src/**/*.js src/**/**/*.js",
Expand Down
Loading