Test for Gutenberg Aztec dependency update #6201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as I can see, so far we duplicated `RNTAztecView.podspec` in this repo based on the version in Gutenberg. This meant doing things such as synchronizing updating the `WordPress-Aztec-iOS` dependency in Gutenberg and then in this repo. By reading the podspec from Gutenberg instead of duplicating it we fulfill the dependency requirement for the XCFramework without needing to update a file twice. To bump the Aztec dependency, we only need to update Gutenberg itself. I suspect `RNTAztecView.podspec` was defined locally because in the past we had something that read it, but that is no longer the case, even in the legacy `Gutenberg.podspec` that's still tracked in the repo but no longer used in our main client, WordPress iOS. Notice how the dependency is referred in the standard form here: https://github.com/wordpress-mobile/gutenberg-mobile/blob/c70afb8da680196206b6f7f50b7d76c9b3cb51ba/Gutenberg.podspec#L27 That notation means that CocoaPods would look for it among its sources. If we were reading it from the repo, we'd need to specify it with `path:`. That's all to say, I consider this change safe to make.
mokagio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test to make sure WordPress/gutenberg#54453 integrates with gutenberg-mobile.