Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read RNTAztecView.podspec from its source in Gutenberg #6200

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Sep 14, 2023

As far as I can see, so far we duplicated RNTAztecView.podspec in this repo based on the version in Gutenberg.

This meant doing things such as synchronizing updating the WordPress-Aztec-iOS dependency in Gutenberg and then in this repo.

By reading the podspec from Gutenberg instead of duplicating it we fulfill the dependency requirement for the XCFramework without needing to update a file twice. To bump the Aztec dependency, we only need to update Gutenberg itself.

I suspect RNTAztecView.podspec was defined locally because in the past we had something that read it, but that is no longer the case, even in the legacy Gutenberg.podspec that's still tracked in the repo but no longer used in our main client, WordPress iOS. Notice how the dependency is referred in the standard form here:

s.dependency 'RNTAztecView'
That notation means that CocoaPods would look for it among its sources. If we were reading it from the repo, we'd need to specify it with path:. That's all to say, I consider this change safe to make.

To test: Verify the XCFramework published successfully.

PR submission checklist:

  • I have considered adding unit tests where possible. – N.A.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary. – N.A.

As far as I can see, so far we duplicated `RNTAztecView.podspec` in this
repo based on the version in Gutenberg.

This meant doing things such as synchronizing updating the
`WordPress-Aztec-iOS` dependency in Gutenberg and then in this repo.

By reading the podspec from Gutenberg instead of duplicating it we
fulfill the dependency requirement for the XCFramework without needing
to update a file twice. To bump the Aztec dependency, we only need to
update Gutenberg itself.

I suspect `RNTAztecView.podspec` was defined locally because in the past we had something that read it, but that is no longer the case, even in the legacy
`Gutenberg.podspec` that's still tracked in the repo but no longer used
in our main client, WordPress iOS. Notice how the dependency is referred
in the standard form here:
https://github.com/wordpress-mobile/gutenberg-mobile/blob/c70afb8da680196206b6f7f50b7d76c9b3cb51ba/Gutenberg.podspec#L27
That notation means that CocoaPods would look for it among its sources.
If we were reading it from the repo, we'd need to specify it with
`path:`. That's all to say, I consider this change safe to make.
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we publish GBM via the XCFramework, I understand that the podspecs RNTAztecView and Gutenberg are no longer needed. I checked that the XCFramework was published successfully and E2E tests passed, so this PR LGTM 🎊 !

@fluiddot fluiddot merged commit b43efc5 into trunk Sep 14, 2023
1 check passed
@fluiddot fluiddot deleted the mokagio/aztec-update branch September 14, 2023 09:13
@fluiddot fluiddot added this to the 1.104.0 (23.3) milestone Sep 14, 2023
dcalhoun added a commit to wordpress-mobile/WordPress-iOS that referenced this pull request Sep 15, 2023
The RNAztec podspec in the `gutenberg-submodule` was removed in favor of
the one within the `gutenberg` submodule. This change was made in the
following:

wordpress-mobile/gutenberg-mobile#6200
dcalhoun added a commit to wordpress-mobile/WordPress-iOS that referenced this pull request Sep 23, 2023
The RNAztec podspec in the `gutenberg-submodule` was removed in favor of
the one within the `gutenberg` submodule. This change was made in the
following:

wordpress-mobile/gutenberg-mobile#6200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants