feat: Insert from URL leverages a bottom sheet #6143
Conversation
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
dcalhoun
force-pushed
the
version-toolkit/gutenberg/feat/insert-from-url-bottom-sheet
branch
from
703def7
to
bf08629
Compare
|
Just wanted to double-check if the commits referencing the broken VideoPress tests would require any additional testing instructions to review this PR (beyond confirming CI checks are passing). |
|
@dcalhoun @derekblank I recently merged #6153 and changed the GitHub Checks. In other PRs, eg #6152, I took it upon myself to merge |
dcalhoun
force-pushed
the
version-toolkit/gutenberg/feat/insert-from-url-bottom-sheet
branch
from
74c0b30
to
9e4a9e9
Compare
@derekblank yes, testing the VideoPress block is relevant. The automated test file changes represent the UI changes introduced. The same testing steps outlined in WordPress/gutenberg#54096 could be performed against the VideoPress block. I tested the VideoPress block myself now and did not encounter any regressions. Will you please test and review the changes as you see fit? I'll move forward with merging whenever you feel comfortable approving this PR. 🙇🏻 |
There was a problem hiding this comment.
I tested the VideoPress block following the steps in WordPress/gutenberg#54096 and did not encounter any regressions. iPhone SE / Samsung Galaxy S20 FE 🚀
This package is no longer installed as its usage was replaced.
Skipping the test to enable prototype builds while I work to address the test failures.
This reverts commit bf08629.
Update the test flow to match the new bottom sheet UI.
dcalhoun
force-pushed
the
version-toolkit/gutenberg/feat/insert-from-url-bottom-sheet
branch
from
baf0ada
to
f5767bf
Compare
dcalhoun
deleted the
version-toolkit/gutenberg/feat/insert-from-url-bottom-sheet
branch
Related PRs
Description
This PR is generated by
version-toolkitto downstream the changes forgutenbergsubmodule.