Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.98.1 #5915

Merged
merged 10 commits into from
Jun 30, 2023
Merged

Release 1.98.1 #5915

merged 10 commits into from
Jun 30, 2023

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Jun 29, 2023

Release for Gutenberg Mobile 1.98.1

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Change 1

Test plan

Once the installable builds of the main apps are ready, we will test the changes to the editor on both iOS and Android.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

dcalhoun added 3 commits June 29, 2023 10:35
Capture result of `bundle exec pod install` within the `ios-xcframework`
directory. while the XCFramework is not currently used for WordPress iOS
integration, this is required to resolve CI failures.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This captures the result of bundle exec pod install within the ios-xcframework directory. while the XCFramework is not currently used for WordPress iOS integration, this is required to resolve CI failures.

@dcalhoun
Copy link
Member Author

We cannot resolve the merge conflicts in this branch or WordPress/gutenberg#52126 until after we integrate the release into the host apps. This means some CI tasks in WordPress/gutenberg#52126 will remain failing until that point.

@dcalhoun dcalhoun marked this pull request as ready for review June 29, 2023 18:38
@derekblank derekblank self-requested a review June 29, 2023 23:05
Copy link
Contributor

@derekblank derekblank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending conflict resolution, LGTM per successful testing in the main app builds. 🚀

@dcalhoun dcalhoun enabled auto-merge June 30, 2023 15:39
@dcalhoun dcalhoun merged commit bb6460f into trunk Jun 30, 2023
@dcalhoun dcalhoun deleted the release/1.98.1 branch June 30, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants