Exclude ios-xcframework folder when resolving modules in Metro
#5819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
commented
May 31, 2023
| @@ -21,6 +21,9 @@ const nodeModulePaths = [ | |||
| const possibleModulePaths = ( name ) => | |||
| nodeModulePaths.map( ( dir ) => path.join( process.cwd(), dir, name ) ); | |||
|
|
|||
| // Exclude `ios-xcframework` folder to avoid conflicts with packages contained in Pods. | |||
| gutenbergMetroConfigCopy.resolver.blockList = [ /ios-xcframework\/.*/ ]; | |||
There was a problem hiding this comment.
The folder is excluded using the blockList configuration parameter of Metro.
geriux
approved these changes
May 31, 2023
|
Great work @fluiddot ! Thank you so much |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue mentioned in wordpress-mobile/release-toolkit-gutenberg-mobile#116 (comment).
We need to exclude the
ios-xcframeworkfolder in Metro configuration to avoid conflicts when resolving modules. Specifically due to the potential presence ofpackage.jsonfiles in Pods.To test:
The issue this PR aims to fix can only be reproduced when installing the Pods of
ios-xcframework.cd ios-xcframework && bundle install && bundle exec pod install && cd ...npm run bundle:android.NOTE: The issue could be also reproduced by connecting the Metro server to the app.
PR submission checklist: