Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.95.0 #5763

Merged
merged 9 commits into from
May 12, 2023
Merged

Release 1.95.0 #5763

merged 9 commits into from
May 12, 2023

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented May 11, 2023 •
edited
Loading

Release for Gutenberg Mobile 1.95.0

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Fix crash when trying to convert to regular blocks an undefined/deleted reusable block

Tapping on a nested block now gets focus directly instead of having to tap multiple times depending on the nesting levels

Use host app namespace in reusable block message

Add fullscreen embed preview to Android

⚠️ NOTE: No need to test this as VideoPress block is not available in this release.

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

@fluiddot fluiddot mentioned this pull request May 11, 2023
Merged
@fluiddot
Update Gutenberg ref
f7bbd0b
@fluiddot
Update Jetpack ref
df1930f 
This commit corrects the Jetpack reference as it was pointing to a PR's branch instead of `trunk`.
@fluiddot
Update bundle
1c0cccb
@fluiddot
Update Gutenberg ref
19f0579
@fluiddot
Update release notes
5fcc532
This was referenced May 11, 2023
Merged
Merged
@fluiddot fluiddot marked this pull request as ready for review May 11, 2023 16:00
@fluiddot fluiddot merged commit 000501a into trunk May 12, 2023
@fluiddot fluiddot deleted the release/1.95.0 branch May 12, 2023 09:48
@fluiddot
Copy link
Contributor Author

fluiddot commented May 16, 2023 •
edited
Loading

🟢 Writing Flow checklist (iOS)

Build: 22.4.0.0
Device: iPhone 11 (iOS 15.4.1)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@fluiddot
Copy link
Contributor Author

fluiddot commented May 16, 2023 •
edited
Loading

🟢 Unsupported Block Tests (iOS)

Build: 22.4.0.0
Device: iPhone 11 (iOS 15.4.1)

  • TC001 - User can edit unsupported blocks on Simple WP.com sites
  • TC002 - User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 - Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 - Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 - Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 - Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@fluiddot
Copy link
Contributor Author

fluiddot commented May 16, 2023 •
edited
Loading

🟡 Included Changes (iOS)

Build: 22.4.0.0
Device: iPhone 11 (iOS 15.4.1)

@fluiddot
Copy link
Contributor Author

fluiddot commented May 16, 2023 •
edited
Loading

🟢 Functionality Test Suites - Test Suite 1 (iOS)

Build: 22.4.0.0
Device: iPhone 11 (iOS 15.4.1)

Gallery - 1

  • Gallery block - Close/Re-open post with an ongoing image upload - TC001
  • Gallery block - Close post with an ongoing image upload - TC002

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009

Gallery - 3

  • Gallery block - Add Gallery Caption - TC003
  • Gallery block - Add Gallery Image Caption - TC04
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Columns - 1

  • Columns - Multiple slider in columns parent - TC011
  • Columns - Check if Column placeholders is visible for the unselected state - TC001
  • Columns - Appearance in vertical device position (vertical layout) - TC004

Columns - 2

  • Columns - Max limit of Column number - TC002
  • Columns - Deep nesting is possible (iOS only)- TC003
  • Columns - Appearance in horizontal device position (horizontal layout) - TC005

Columns - 3

  • Columns - Mover direction - TC006
  • Columns - Check if Column placeholder is render in nested structure - TC007
  • Columns - Unselected Column placeholder is stretched to content in nested structure- TC008

MediaText - 1

  • Media Text block - Insert image from device (failing) - TC001
  • Media Text block - Close/Re-open post with an ongoing image upload - TC003

MediaText - 2

  • Media Text block - Insert video from device - TC002-v
  • Media Text block - Insert image from device - TC002-i

MultipleUpload - 1

  • Simultaneous uploads - TC001

Cover - 1

  • Cover - Add image background from WordPress Media library - TC001
  • Cover - Image focal point is rendered properly - TC002
  • Cover - Custom color is rendered properly - TC002

Editor Theme - 1

  • Default Colors - Check that default colors still load - TC001
  • Default Gradients - Check that default gradients still load - TC002
  • Custom Colors - Check that custom colors load in the editor - TC003

Social Icons - 1

  • Active icon gets product color - TC001
  • Social icon forwarding to the link - TC002

@SiobhyB
Copy link
Contributor

SiobhyB commented May 16, 2023 •
edited
Loading

🟢 Writing Flow checklist (Android)

Build: 22.4-rc-1
Device: Pixel 6 (Android 13)

General

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging

Undo / Redo - Test Cases

@SiobhyB
Copy link
Contributor

SiobhyB commented May 16, 2023 •
edited
Loading

🟢 Unsupported Block Tests (Android)

Build: 22.4-rc-1
Device: Pixel 6 (Android 13)

  • TC001 - User can edit unsupported blocks on Simple WP.com sites
  • TC002 - User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 - Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 - Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 - Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 - Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@SiobhyB
Copy link
Contributor

SiobhyB commented May 16, 2023 •
edited
Loading

🟢 Included Changes (Android)

Build: 22.4-rc-1
Device: Pixel 6 (Android 13)

@SiobhyB
Copy link
Contributor

SiobhyB commented May 16, 2023 •
edited
Loading

🟢 Functionality Test Suites - Test Suite 5 (Android)

Build: 22.4-rc-1
Device: Pixel 6 (Android 13)

Video block - 1

  • Video block - Insert video from device (failing) - TC001
  • Video block - Close/Re-open post with an ongoing video upload - TC004

Video block - 2

  • Video block - Insert video from device (cancel) - TC002
  • Video block - Close post with an ongoing video upload - TC005
  • Video block - Add Caption - TC003

File block - 1

  • File block - Upload completes successfully from the device library - TC001
  • File block - Insert completes successfully from the WordPress Media library - TC002
  • File block - Upload fails from the device library - TC003
  • File block - Stop the file upload before it completes - TC004

File block - 2

  • File block - Close the post with an ongoing file upload - TC005
  • File block - Replace the selected files - TC006
  • File block - Change the alignment in the File Block - TC007
  • File block - The Link To Block Setting should open - TC008

File block - 3

  • File block - Open link in new tab - TC009
  • File block - Show/hide download button (Block Settings only) - TC010
  • File block - Copy file URL - TC011
  • File block - Close/Re-open post with an ongoing file upload - TC012

Audio block - 1

  • Audio block - Upload completes successfully from the device library - TC001
  • Audio block - Insert completes successfully from the WordPress Media library - TC002

Audio block - 2

  • Audio block - Upload fails from the device library - TC003
  • Audio block - Stop the audio file upload before it completes - TC004

Audio block - 3

  • Audio block - Close the post with an ongoing audio file upload - TC005
  • Audio block - Replace the selected files - TC006
  • Audio block - Change the alignment in the Audio Block - TC007

Audio block - 4

  • Audio block - Autoplay setting - TC008
  • Audio block - Loop setting - TC009
  • Audio block - Close/Re-open post with an ongoing audio file upload - TC010

Reusable block - 1

  • Reusable block - Add block - TC001
  • Reusable block - Convert to regular blocks - TC002

Reusable block - 2

  • Reusable block - Deleted reusable block - TC003
  • Reusable block - Recursive block rendering - TC004

Embed block - 1

  • Embed block - Inline previews are rendered correctly for the top 5 most-used providers - TC001

Embed block - 2

  • Embed block - Inline previews are rendered accordingly for each alignment option - TC002

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcalhoun dcalhoun dcalhoun approved these changes

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fluiddot @SiobhyB @dcalhoun