Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Keyboard Aware Flatlist #5533

Merged
merged 6 commits into from
Apr 10, 2023
Merged

Remove Keyboard Aware Flatlist #5533

merged 6 commits into from
Apr 10, 2023

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Mar 6, 2023 •
edited
Loading

Related PRs:

This PR fixes a high-priority bug on iOS where the scroll would jump to the top and then scroll back to the currently focused text input.

To test check the Gutenberg PR description.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

This was referenced Mar 6, 2023
Merged
Merged
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 6, 2023 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@geriux geriux force-pushed the remove-keyboard-aware-flatlist branch from 3fb63d5 to faa329e Compare March 10, 2023 12:32
@geriux geriux marked this pull request as ready for review March 10, 2023 16:22
@geriux geriux force-pushed the remove-keyboard-aware-flatlist branch 2 times, most recently from 091cf80 to 9a34ecf Compare March 23, 2023 12:19
@geriux geriux mentioned this pull request Mar 28, 2023
Merged
4 tasks
@geriux geriux requested a review from fluiddot March 29, 2023 06:55
@geriux geriux force-pushed the remove-keyboard-aware-flatlist branch from f12f86b to e242b07 Compare March 29, 2023 07:10
@geriux geriux modified the milestone: 1.92.0 (22.1) Mar 29, 2023
@geriux geriux force-pushed the remove-keyboard-aware-flatlist branch from 946c31f to d3ea2cd Compare April 3, 2023 15:36
fluiddot
fluiddot approved these changes Apr 5, 2023
View reviewed changes
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#48791 (review).

@geriux geriux force-pushed the remove-keyboard-aware-flatlist branch from d5812a5 to 7f5b640 Compare April 10, 2023 12:19
@geriux geriux added this to the 1.93.0 (22.2) milestone Apr 10, 2023
@geriux geriux merged commit 85f57f7 into trunk Apr 10, 2023
@geriux geriux deleted the remove-keyboard-aware-flatlist branch April 10, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluiddot fluiddot fluiddot approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
1.93.0 (22.2)
Development

Successfully merging this pull request may close these issues.
2 participants
@geriux @fluiddot