Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add networking support (part 1) #548

Merged
merged 2 commits into from
Feb 7, 2019
Merged

Conversation

Tug
Copy link
Contributor

@Tug Tug commented Feb 6, 2019

This PR is required for task #202

First it fixes how gutenberg is loaded on boot: we need to initialize some data middleware before calling our App component. Just like gutenberg is doing for the web in the plugin (server-side) part: https://github.com/WordPress/gutenberg/blob/master/lib/client-assets.php#L205

TODO:

@Tug Tug self-assigned this Feb 6, 2019
@Tug Tug requested review from hypest and etoledom February 6, 2019 18:33
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the getMedia( id ) call from Image block, and it effectively call apiFetch with the corresponding path.
As you mentioned, now we need to make that call work.

Thank you so much @Tug ! This one was for sure a tricky one! ✨

@Tug
Copy link
Contributor Author

Tug commented Feb 7, 2019

Thanks for reviewing @etoledom :)
Let's merge this and continue the work in another PR!

@Tug Tug merged commit 0aeeda6 into develop Feb 7, 2019
@Tug Tug deleted the update/gutenberg-store-setup branch February 7, 2019 08:38
@Tug Tug changed the title Add networking support Add networking support (part 1) Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants